-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[WebProfilerBundle] fix wrong variable for profiler counting ajax requests #26373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ping @xkobal @Simperfit for double checking |
That was |
Let me take this time to test this. But I think this is right too. I'll test it today. |
@nicolas-grekas sorry for hijacking this PR. As i'm having trouble with the code affected in this PR it might make sense to coordinate this here before I create a PR.
(order_now is the pagename and references to the profiler code) |
@n3o77 can you test the code in this PR and report if it fixes the issue for you? |
@nicolas-grekas yes, fixes the problem for me. Thank you @marinnicolae . |
Same problem is in v2.8 |
@n3o77 Yep, problem is on v2.8 also - Fix works good. Thank you @marinnicolae |
Thank you @marinnicolae. |
…ting ajax requests (Marin Nicolae) This PR was squashed before being merged into the 2.7 branch (closes #26373). Discussion ---------- [WebProfilerBundle] fix wrong variable for profiler counting ajax requests | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26364 | License | MIT | Doc PR | symfony/symfony-docs#... Symfony WebProfiler base js change variable tbodies to tbody for counting Ajax Requests. Commits ------- 0fb83af [WebProfilerBundle] fix wrong variable for profiler counting ajax requests
Can anybody please check if the code on 3.4 works as expected? |
@nicolas-grekas Just tested on v3.4.5 and AjaxRequests does not appear cuz there are not appending in profiler bar. Will try to create a PR with the fix on 3.4 branch soon. |
@marinnicolae please note that branch 3.4 already has some fixes, so might be just fixed already, you'll tell :) |
Symfony WebProfiler base js change variable tbodies to tbody for counting Ajax Requests.