Skip to content

[WebProfilerBundle] Render file links for twig templates (Fix #24355) #24356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[WebProfilerBundle] Render file links for twig templates (Fix #24355) #24356

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2aeed1f
Fix URL generation by escaping file path for JS
Sep 28, 2017
e0efbcc
Revert "Fix URL generation by escaping file path for JS"
Sep 28, 2017
4d20a83
Reattempt to fix #24356
Sep 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Symfony/Bridge/Twig/Extension/CodeExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,10 @@ public function formatFile($file, $line, $text = null)
*/
public function getFileLink($file, $line)
{
//If on Windows, we must escape $file if it contains backslash char
if('\\' === DIRECTORY_SEPARATOR && FALSE !== strpos($file, '\\')) {
$file = addslashes($file);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said before, this is a nogo as most cases don't want such escaping. You will probably break it for all other users.

}
if ($fmt = $this->fileLinkFormat) {
return is_string($fmt) ? strtr($fmt, array('%f' => $file, '%l' => $line)) : $fmt->format($file, $line);
}
Expand Down