Use new configuration depreciation method #24025
Conversation
| @@ -64,8 +64,6 @@ public function boot() | |||
| ErrorHandler::register(null, false)->throwAt($this->container->getParameter('debug.error_handler.throw_at'), true); | |||
|
|
|||
| if ($this->container->hasParameter('kernel.trusted_proxies')) { | |||
| @trigger_error('The "kernel.trusted_proxies" parameter is deprecated since version 3.3 and will be removed in 4.0. Use the Request::setTrustedProxies() method in your front controller instead.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
this change should be reverted as the notice is not about the framework.trusted_proxies config option but the corresponding kernel parameter, triggering is still relevant. If you think it should be rediscussed, that should be done on 3.3 where it has been introduced.
|
I don’t understand why the tests failed on travis. I can’t reproduce the problem on my computer (with php 7.0 and |
|
Should be better after #24083. |
This PR was merged into the 3.4 branch. Discussion ---------- Fix ability to deprecate a config node | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | not yet released | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22382 | License | MIT | Doc PR | n/a Unlocks #24025 Commits ------- fc91869 Fix ability to deprecate a config node
|
rebase needed to account for #24083. |
|
Done, thank you @chalasr. It’s better but it still failed with hhvm and php 5.5 due to deprecation notices. |
|
@sanpii Looks like this triggers extra deprecations, I suspect that we trigger when we should not (e.g. because the node has a default value, we trigger even if not explicitly set). I'll look into later today. |
There was a problem hiding this comment.
That was the case (#24025 (comment)), added a commit that makes nodes trigger deprecations only if the value is explicitly set. PR looks good to me.
|
VariableNode (= all nodes which are not |
This PR was merged into the 3.4 branch. Discussion ---------- Use new configuration depreciation method | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | N/A | License | MIT | Doc PR | N/A In keeping with #22382 Commits ------- 4a62cc6 Do not trigger deprecation if node has not been explicitly filled 012e381 Use new configuration node depreciation method
In keeping with #22382