Skip to content

[Process] Fix parsing args on Windows #23477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2017
Merged

[Process] Fix parsing args on Windows #23477

merged 1 commit into from
Jul 12, 2017

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23455
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Jul 11, 2017
@nicolas-grekas nicolas-grekas mentioned this pull request Jul 11, 2017
Closed
@nicolas-grekas
Copy link
Member Author

failure unrelated

@nicolas-grekas nicolas-grekas merged commit 8826da1 into symfony:3.3 Jul 12, 2017
nicolas-grekas added a commit that referenced this pull request Jul 12, 2017
@nicolas-grekas
bug #23477 [Process] Fix parsing args on Windows (nicolas-grekas)
e659ec1 
This PR was merged into the 3.3 branch.

Discussion
----------

[Process] Fix parsing args on Windows

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23455
| License       | MIT
| Doc PR        | -

Commits
-------

8826da1 [Process] Fix parsing args on Windows
@fabpot fabpot mentioned this pull request Jul 17, 2017
Merged
@nicolas-grekas nicolas-grekas deleted the proc-esc branch July 24, 2017 14:01
@abkrim abkrim mentioned this pull request Aug 7, 2017
Closed
@abkrim
Copy link

abkrim commented Aug 7, 2017 •
edited
Loading

I've updated Process to 3.3.6 and I've issue.

I use component trought Laravel 5.4 on mac os x for development and Ubuntu 16.0.4 on production

$process = "some:process option";

$ps = new Process('ps aux|grep "'.$process.'"| grep -v grep');

if (!$ps->isSuccessful()) {
                // Failed sometimes
                Log::critical("Check other instance running failed");
                exit(); 
} else { 
    // Do something for verify if other instance is running
   $run = $ps->getOutput();
   ....
}

On Mac Os X work fine, on Ubuntu any times work (a few) and most fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Process Status: Needs Review
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @abkrim @fabpot @carsonbot