Skip to content

[DI][DX] Fix missing autoconfigure in container debug #22656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2017
Merged

[DI][DX] Fix missing autoconfigure in container debug #22656

merged 1 commit into from
May 7, 2017

Conversation

chr-hertel
Copy link
Contributor

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Added missing autoconfigure flag for debug:container with service id.

@carsonbot carsonbot added Status: Needs Review DependencyInjection DX DX = Developer eXperience (anything that improves the experience of using Symfony) Bug labels May 6, 2017
chalasr
chalasr requested changes May 7, 2017
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The XML/Markdown/JSON descriptors need to be updated too

@chr-hertel
Copy link
Contributor Author

@chalasr they were already updated by the initial PR #22234

chalasr
chalasr approved these changes May 7, 2017
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh indeed, sorry. 👍 reviewed

@fabpot
Copy link
Member

fabpot commented May 7, 2017

Good catch, thanks @chr-hertel.

@fabpot fabpot merged commit f50afad into symfony:master May 7, 2017
fabpot added a commit that referenced this pull request May 7, 2017
@fabpot
minor #22656 [DI][DX] Fix missing autoconfigure in container debug (C…
b0236ce 
…hristopher Hertel)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[DI][DX] Fix missing autoconfigure in container debug

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Added missing autoconfigure flag for `debug:container` with service id.

Commits
-------

f50afad fixed missing autoconfigure in container debug
@ghost ghost deleted the debug_autoconfigure branch May 7, 2017 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug DependencyInjection DX DX = Developer eXperience (anything that improves the experience of using Symfony) Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chr-hertel @fabpot @chalasr @carsonbot