Skip to content

[WebDebugToolbar] Adding options to WebDebugToolbar #17263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[WebDebugToolbar] Adding options to WebDebugToolbar #17263

wants to merge 2 commits into from

Conversation

loconox
Copy link

@loconox loconox commented Jan 5, 2016

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets no
License MIT
Doc PR

When the machine is very slow or when there are lot of sub requests, the WDT may not be able to show up after 5 tries every 500ms.
I'm suggesting to add some options to configure how many tries before the script stop trying to load the bar and even to configure the delay between each tries.

@javiereguiluz
Copy link
Member

Instead of defining configuration values, I think it would be better to apply some reasonable values (3 retries, 5 sec. ?) and show an error message when the toolbar doesn't load. I remember that there was an old issue or pull request about this.

@loconox
Copy link
Author

loconox commented Jan 5, 2016

My point is that a reasonnable value may not have sens on some situations. In particular, between php5 and php7, the load may be much faster. Or dev on a very slow computer with xdebug and php5, the page may take several seconds to load.

@loconox loconox changed the title Adding options to WebDebugToolbar [WebDebugToolbar] Adding options to WebDebugToolbar Jan 5, 2016
@loconox
Copy link
Author

loconox commented Jan 5, 2016

I didn't look into the code in detail but I wanted to note that the behavior of the WDT seems different between the version <=2.7 and 2.8.
With 2.7 the bar may show up correctly but an memory error may be raised on the detailed page. Whereas with 2.8, the bar doesn't load without any php error but a 404.

@fabpot
Copy link
Member

fabpot commented Jan 5, 2016

See #15670 for the prior discussion on this topic. A good solution is mentioned there but nobody implemented yet.

@fabpot fabpot closed this Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants