Skip to content

[FrameworkBundle][HttpKernel] the finder is required to discover bundle commands #17057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[FrameworkBundle][HttpKernel] the finder is required to discover bundle commands #17057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d8eb6c
the finder is required to discover bundle commands
xabbuh Dec 17, 2015
e97bcb9
move symfony/finder from require-dev to require
xabbuh Dec 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Symfony/Bundle/FrameworkBundle/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"symfony/dependency-injection": "~2.3",
"symfony/config": "~2.3,>=2.3.12",
"symfony/event-dispatcher": "~2.1",
"symfony/finder": "~2.0,>=2.0.5",
"symfony/http-foundation": "~2.3,>=2.3.19",
"symfony/http-kernel": "~2.3,>=2.3.22",
"symfony/filesystem": "~2.3",
Expand All @@ -34,7 +35,6 @@
"symfony/console": "~2.3",
"symfony/css-selector": "~2.0,>=2.0.5",
"symfony/dom-crawler": "~2.0,>=2.0.5",
"symfony/finder": "~2.0,>=2.0.5",
"symfony/intl": "~2.3",
"symfony/security": "~2.3",
"symfony/form": "~2.3.31",
Expand All @@ -45,7 +45,6 @@
},
"suggest": {
"symfony/console": "For using the console commands",
"symfony/finder": "For using the translation loader and cache warmer",
"symfony/form": "For using forms",
"symfony/validator": "For using validation",
"symfony/serializer": "For using the serializer service",
Expand Down
4 changes: 4 additions & 0 deletions src/Symfony/Component/HttpKernel/Bundle/Bundle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,10 @@ public function registerCommands(Application $application)
return;
}

if (!class_exists('Symfony\Component\Finder\Finder')) {
throw new \RuntimeException('You need the symfony/finder component to register bundle commands.');
}

$finder = new Finder();
$finder->files()->name('*Command.php')->in($dir);

Expand Down