Unique entity custom message #16345

jamyouss · 2015-10-26T11:10:15Z

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT
Doc PR	-

Add the possibility to have custom message for unique entity constraint.
For example if we have a collection of entities in a form, the message can be more expressive.

Example:

/**
 * Town
 *
 * @ORM\Entity()
 * @UniqueEntity(fields={"city"}, message="The city '{{ city }}' is already used.")
 */
class Town
{

Reopen PR #15201 based now on branch 2.8

jamyouss · 2015-10-28T15:27:30Z

ping @stof @xabbuh

fabpot · 2015-10-29T18:39:55Z

Looks like there is a problem here as many commits are not related to the changes made here.

jamyouss · 2015-10-29T20:01:25Z

@fabpot Yes my PR was based on 2.6 but had some travis errors not related to my changes.
That why i merge the 2.8 branch into it and open a new PR.

Do i need to do a new PR ? (a clean PR)

xabbuh · 2015-10-29T21:53:11Z

@Razmo You can rebase your changes on the current 2.8 branch and do a forced push to your branch afterwards. Your pull request will be automatically synced.

jamyouss · 2015-10-30T09:01:10Z

@xabbuh Thanks, it works 👍

nicolas-grekas · 2015-12-09T10:07:12Z

Please do not merge but rebase instead. In fact, can you squash your commits in one please?
(or in two in your case, one for each author)

jamyouss · 2015-12-09T10:42:16Z

Ok going to squash my commits in one (there is only one author, just done a mistake on my config for first commits) and i'll rebase on 2.8.

jamyouss · 2015-12-09T13:54:59Z

@nicolas-grekas done

xabbuh · 2015-12-10T20:15:18Z

src/Symfony/Bridge/Doctrine/Validator/Constraints/UniqueEntityValidator.php

@@ -135,13 +136,29 @@ public function validate($entity, Constraint $constraint)
        $errorPath = null !== $constraint->errorPath ? $constraint->errorPath : $fields[0];
        $invalidValue = isset($criteria[$errorPath]) ? $criteria[$errorPath] : $criteria[$fields[0]];

+        $vars = array();


That's not necessary, is it?

indeed, it is useless

I'm going to remove it

xabbuh · 2015-12-10T20:16:45Z

👍 LGTM

stof · 2015-12-10T20:53:36Z

src/Symfony/Bridge/Doctrine/Validator/Constraints/UniqueEntityValidator.php

+        if (preg_match_all('/{{ ([a-zA-Z0-9_]+) }}/', $constraint->message, $vars) > 0) {
+
+            if (!class_exists('Symfony\\Component\\PropertyAccess\\PropertyAccess')) {
+                throw new \RuntimeException('Unable to access entity property as the Symfony PropertyAccess is not installed.');


you should probably explain why it is necessary

PropertyAccess component should be ship with standard edition right ? Why this check ?

@dupuchba You can use the Doctrine bridge without using the full framework.

ok, I am not sure if it's widespread but fair enough ! Thx @xabbuh

fabpot · 2016-01-27T05:17:06Z

Any news on this one?

jamyouss · 2016-01-27T08:11:36Z

@fabpot : I'm waiting for @stof explanations of his point (with some examples) because i didn't understand:

this check is a bad idea: when using translation keys, the params are needed, but they are not part of the key

May be you can example me his point ?

jamyouss · 2016-01-29T13:48:18Z

Ping @stof

fabpot · 2016-03-02T13:09:02Z

@Razmo $constraint->message can be two different things, the message itself or a key that can be used to retrieve the real message. For the latter, the key never contains the parameters (blog.title vs Blog {{ title }}).

fabpot · 2016-06-13T20:08:36Z

@jamyouss Do you need help to finish this one?

jamyouss · 2016-06-14T12:54:46Z

@fabpot Yes please.
I only see one solution. Inject the translator in UniqueEntityValidator class, translate the message and make the replacement after. By this way we make the replacement on the final message. The drawback is that ConstraintViolationBuilder already do the translation.

Do you have another idea ?

nicolas-grekas · 2017-07-11T14:48:50Z

@jamyouss would you mind rebasing on branch 3.4 and changing the target branch on github also to 3.4?

fabpot · 2020-02-03T15:19:28Z

Closing as this PR is stale and it cannot be merged as is anyway.

carsonbot added the Status: Needs Review label Oct 26, 2015

xabbuh reviewed Dec 10, 2015
View reviewed changes

stof reviewed Dec 10, 2015
View reviewed changes

javiereguiluz added Feature Validator labels Mar 3, 2016

Add custom message for unique entity constraint

c53278a

nicolas-grekas added this to the 3.x milestone Dec 6, 2016

jamyouss changed the base branch from 2.8 to 3.4 August 6, 2017 14:36

nicolas-grekas modified the milestones: 3.4, 4.1 Sep 28, 2017

nicolas-grekas modified the milestones: 4.1, next Apr 20, 2018

fabpot closed this Feb 3, 2020

nicolas-grekas modified the milestones: next, 5.1 May 4, 2020

Uh oh!

Unique entity custom message #16345

Unique entity custom message #16345

Uh oh!

Conversation

jamyouss commented Oct 26, 2015

Uh oh!

jamyouss commented Oct 28, 2015

Uh oh!

fabpot commented Oct 29, 2015

Uh oh!

jamyouss commented Oct 29, 2015

Uh oh!

xabbuh commented Oct 29, 2015

Uh oh!

jamyouss commented Oct 30, 2015

Uh oh!

nicolas-grekas commented Dec 9, 2015

Uh oh!

jamyouss commented Dec 9, 2015

Uh oh!

jamyouss commented Dec 9, 2015

Uh oh!

xabbuh Dec 10, 2015

Choose a reason for hiding this comment

Uh oh!

stof Dec 10, 2015

Choose a reason for hiding this comment

Uh oh!

jamyouss Dec 11, 2015

Choose a reason for hiding this comment

Uh oh!

xabbuh commented Dec 10, 2015

Uh oh!

stof Dec 10, 2015

Choose a reason for hiding this comment

Uh oh!

dupuchba Dec 22, 2015

Choose a reason for hiding this comment

Uh oh!

xabbuh Dec 22, 2015

Choose a reason for hiding this comment

Uh oh!

dupuchba Dec 22, 2015

Choose a reason for hiding this comment

Uh oh!

fabpot commented Jan 27, 2016

Uh oh!

jamyouss commented Jan 27, 2016

Uh oh!

jamyouss commented Jan 29, 2016

Uh oh!

fabpot commented Mar 2, 2016

Uh oh!

fabpot commented Jun 13, 2016

Uh oh!

jamyouss commented Jun 14, 2016

Uh oh!

nicolas-grekas commented Jul 11, 2017

Uh oh!

fabpot commented Feb 3, 2020

Uh oh!

Uh oh!