Skip to content

[PropertyAccess] Fail the test if the exception was not thrown on accessing an invalid element #16223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[PropertyAccess] Fail the test if the exception was not thrown on accessing an invalid element #16223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,8 @@ public function testGetValueNotModifyObjectException()

try {
$propertyAccessor->getValue($object, 'firstName[1]');

$this->fail('Expected an exception to be thrown when accessing an invalid element.');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove the try catch, you could make a separate test with an @expectedException for this case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a separate test case for this already. I just realised there's no need to test this again here.

} catch (NoSuchIndexException $e) {
}

Expand Down