[Translation] merge all fallback catalogues messages into current catalo... #13981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitboudad
force-pushed
the
translation_fallback_cache
branch
from
d201dce to
2c8aeef
Compare
| } | ||
| } else { | ||
| $current = ''; | ||
| $fallbackContent = ''; |
There was a problem hiding this comment.
fallbackContent is already ''
aitboudad
force-pushed
the
translation_fallback_cache
branch
2 times, most recently
from
b1a60e9 to
9de6fed
Compare
| } | ||
| foreach ($messages as $domain => $domainMessages) { | ||
| $catalogue->add($domainMessages, $domain); | ||
| } |
There was a problem hiding this comment.
I would add return ''; here and remove the else.
aitboudad
force-pushed
the
translation_fallback_cache
branch
from
9de6fed to
6eb5e73
Compare
|
Thank you @aitboudad. |
fabpot
added a commit
that referenced
this pull request
Mar 25, 2015
…nto current catalo... (aitboudad) This PR was merged into the 2.7 branch. Discussion ---------- [Translation] merge all fallback catalogues messages into current catalo... | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Fixed tickets | ~ | Tests pass? | yes | License | MIT The amount of reduced memory depend on number of defined fallbacks and the size of messages. For example if we defined 2 fallbacks and we have a large file like ~20 mb we save (~40 mb)  Commits ------- 6eb5e73 [Translation] merge all fallback catalogues messages into current catalogue.
This was referenced Apr 7, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The amount of reduced memory depend on number of defined fallbacks and the size of messages.
For example if we defined 2 fallbacks and we have a large file like ~20 mb we save (~40 mb)