[PropertyAccess] stop overwriting once a reference is reached (2nd) #13831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| array(new TestClass(array('foo' => 'bar')), 'publicGetSetter[foo]', 'bar'), | ||
| array(new TestClass(new TestClass('bar')), 'publicGetter.publicGetSetter', 'bar'), | ||
| array(new TestClass(array('foo' => new TestClass('bar'))), 'publicGetter[foo].publicGetSetter', 'bar'), | ||
| array(new TestClass(new TestClass(new TestClass('bar'))), 'publicGetter.publicGetSetter.publicGetSetter', 'bar'), |
There was a problem hiding this comment.
publicGetter.publicGetter.publicGetSetter should be enough (no need for GetSetter in middle)
|
Thanks for the work. Looks very good now. 👍 I was wondering if there are circumstances where a object reference must be repopulated downwards. The only thing I could image is Value Objects like PSR-7 Uri where the "setter" creates new objects which would need to be set on the root, e.g. So this change here is indeed a bug fix and does not break anything. It should also be merged in 2.6. |
Tobion
added a commit
that referenced
this pull request
Mar 3, 2015
…hed (3rd) (bananer) This PR was squashed before being merged into the 2.6 branch (closes #13835). Discussion ---------- [PropertyAccess] stop overwriting once a reference is reached (3rd) I commited with a different email address in [PR 13831](#13831), so here is the third attempt. Also removed unnecessary test as suggested by @Tobion | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | [13731](#13731) | License | MIT | Doc PR | none I added test cases for the scenario described in my issue. After looking through the PropertyAccessor source my conclusion was that there is no reason to overwrite parents of references, so I changed that. None of the previous test cases disagreed and my new tests also passed. Or maybe I got it all wrong, I'm willing to learn. Commits ------- d733a88 [PropertyAccess] stop overwriting once a reference is reached (3rd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated, squashed version of PR 13826
I added test cases for the scenario described in my issue. After looking through the PropertyAccessor source my conclusion was that there is no reason to overwrite parents of references, so I changed that. None of the previous test cases disagreed and my new tests also passed.
Or maybe I got it all wrong, I'm willing to learn.