-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[VarDumper] fix very special vars handling #13351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nicolas-grekas
commented
Jan 9, 2015
Q | A |
---|---|
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | #13235 |
License | MIT |
Doc PR | - |
40ef355
to
5ee47da
Compare
PR is ready. Fabbot is drunk and Travis will be fixed after subtree-splitting (for what is concerned by this) |
public function testSpecialVars56() | ||
{ | ||
if (PHP_VERSION_ID < 50600) { | ||
$this->markTestSkipped('PHP 5.6 or the symfony_debug extension is required.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should you check for the extension being loaded to avoid skipping in this case ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the extension does not help here, I'm going to update the message
AFAICT, the PHP-CS-Fixer expects the for the indentation change at the end, I'm quite sure it is a bug in the PHP-CS-Fixer logic to detect closures, which is not taking into account the possibility to return by reference. I submitted PHP-CS-Fixer/PHP-CS-Fixer#964 |
@fabpot what is actually the Symfony coding standard for the placement of the |
2308390
to
f3b2fe0
Compare
f3b2fe0
to
e26dc2c
Compare
It's a |
Thank you @nicolas-grekas. |
This PR was merged into the 2.6 branch. Discussion ---------- [VarDumper] fix very special vars handling | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13235 | License | MIT | Doc PR | - Commits ------- e26dc2c [VarDumper] fix very special vars handling