-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[JsonResponse] Silent only JSON errors #11418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -201,4 +201,32 @@ public function testSetContent() | |
{ | ||
JsonResponse::create("\xB1\x31"); | ||
} | ||
|
||
/** | ||
* @expectedException Exception | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The warning is converted to an exception by PHPUnit. |
||
* @expectedExceptionMessage Failed calling Symfony\Component\HttpFoundation\Tests\JsonSerializableObject::jsonSerialize() | ||
* @link http://php.net/manual/en/jsonserializable.jsonserialize.php#114688 | ||
*/ | ||
public function testSetContentJsonSerializeError() | ||
{ | ||
if (!interface_exists('JsonSerializable')) { | ||
$this->markTestSkipped('Interface JsonSerializable is available in PHP 5.4+'); | ||
} | ||
|
||
$serializable = new JsonSerializableObject(); | ||
|
||
JsonResponse::create($serializable); | ||
} | ||
} | ||
|
||
if (interface_exists('JsonSerializable')) { | ||
class JsonSerializableObject implements \JsonSerializable | ||
{ | ||
public function jsonSerialize() | ||
{ | ||
trigger_error('This error is expected', E_USER_WARNING); | ||
|
||
return array(); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure this will cover the case properly ? If the error happens early in the error handling, the
json_last_error
might be related to a previous json operation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that's the tricky part.
I can run
json_encode(null)
before to clearjson_last_error()
.But it's still possible to execute
json_encode
orjson_decode
inside aJsonSerializable
object.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most reliable way to know if the error has been triggered by this call to
json_encode
is to check the$errfile
and$errline
.