This repository was archived by the owner on Feb 6, 2022. It is now read-only.
Tweaked the collector priority #116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what would be the behavior on older versions ? |
|
In the old Symfony versions, this panel will appear before any panel which doesn't define the priority (most of them) or define a priority lower than 260 (all of them). For some users it may be confusing because they are used to certain panel order. |
|
Coudln't we use 255 or 254, to keep it after core panels in Symfony 2.7 and older (they are at 255) ? |
|
Good idea! I've used |
|
I'm just waiting for Travis to run (but the Travis quota is per repo owner, and symfony/symfony has a bunch of queued builds right now) |
|
Thank you @javiereguiluz. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In symfony/symfony#16023 we're tweaking the priorities of the toolbar/profiler panels. The 260 value is the right number for SwiftMailer ... but maybe you don't want to merge it yet because this will change a lot the position of the SwiftMailer panel in the profiler/toolbar of Symfony versions older than 2.8.