Adding the extension XML for required by XmlUtils and not installed by default #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It think should be part FrameworkBundle instead 🤔 because that's the one containing the actual XML files. |
|
@sstok is right. |
|
So it may be better I would a pull request on FrameworkBundle and no skeleton? |
|
@flug yes |
|
Oh right let's go 👍 thx |
|
pull request done referenced there : symfony/symfony#22676 |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
May 9, 2017
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #22676). Discussion ---------- [FrameworkBundle] Adding the extension XML | Q | A | ------------- | --- | Branch? | <3.3 | Bug fix? | yes | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->  This pull request is referenced on  <!-- - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. - Please fill in this template according to the PR you're about to submit. - Replace this comment by a description of what your PR is solving. --> Commits ------- 6fe2ad0 [FrameworkBundle] Adding the extension XML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the XML extension which is not installed by default. What throws an exception on the class :
Symfony\Component\Config\Util\XmlUtils