Skip to content

Add support for env vars in phpunit.xml.* #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Add support for env vars in phpunit.xml.* #148

merged 1 commit into from
Sep 12, 2017

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Sep 11, 2017

No description provided.

@fabpot fabpot force-pushed the phpunit-envs branch 2 times, most recently from ce9103d to 531f2d3 Compare September 11, 2017 22:30

<!-- ###+ FooBundle ### -->
<server name="APP_ENV" value="test" />
<server name="APP_DEBUG" value="0" />
Copy link
Member

@yceruto yceruto Sep 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be aligned with default indent 8, regarding to default file structure?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@fabpot fabpot merged commit ab06720 into master Sep 12, 2017
fabpot added a commit that referenced this pull request Sep 12, 2017
This PR was merged into the 1.0-dev branch.

Discussion
----------

Add support for env vars in phpunit.xml.*

Commits
-------

ab06720 added support for env vars in phpunit.xml.*
$data .= ' <!-- '.$value." -->\n";
} else {
$value = $this->options->expandTargetDir($value);
$data .= " <server name=\"$key\" value=\"$value\" />\n";
Copy link
Member

@yceruto yceruto Sep 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to symfony/recipes#170 it shouldn't be <env ... />?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, fixed. Thanks.

@xabbuh xabbuh deleted the phpunit-envs branch September 12, 2017 20:12
javiereguiluz added a commit to symfony/demo that referenced this pull request Sep 19, 2017
This PR was squashed before being merged into the master branch (closes #648).

Discussion
----------

Update to Symfony 3.3.9 and fix latest changes

The [second commit][1] remove the unnecessary configuration for controllers services fixed in symfony/symfony#24126

The third commit update Symfony Flex deps and update `phpunit.xml.dist` env vars according to symfony/recipes#170 and symfony/flex#148

<details>
<summary>See "composer update" log trace.</summary>

```bash
Installing dependencies (including require-dev) from lock file
Package operations: 1 install, 45 updates, 0 removals
  - Updating composer/ca-bundle (1.0.7 => 1.0.8): Downloading (100%)
  - Updating symfony/doctrine-bridge (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/stopwatch (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/routing (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/http-foundation (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/event-dispatcher (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/debug (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/http-kernel (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/flex (v1.0.17 => v1.0.19): Downloading (100%)
  - Updating symfony/finder (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/filesystem (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dependency-injection (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/config (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/class-loader (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/cache (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/framework-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/console (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating doctrine/doctrine-fixtures-bundle (2.3.0 => v2.4.0): Downloading (100%)
  - Updating symfony/asset (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dom-crawler (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/browser-kit (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/css-selector (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/expression-language (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/inflector (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/property-access (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/options-resolver (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/intl (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/form (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/monolog-bridge (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/security (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/security-bundle (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/swiftmailer-bundle (v3.0.3 => v3.0.4): Downloading (100%)
  - Updating symfony/twig-bridge (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/twig-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/translation (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/validator (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/yaml (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/process (v3.3.8 => v3.3.9): Loading from cache
  - Installing composer/semver (1.4.2): Downloading (100%)
  - Updating friendsofphp/php-cs-fixer (v2.5.0 => v2.6.0): Downloading (100%)
  - Updating symfony/var-dumper (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/debug-bundle (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dotenv (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/phpunit-bridge (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/web-profiler-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/web-server-bundle (v3.3.8 => v3.3.9): Loading from cache
Generating autoload files
```
</details>

  [1]: ba751c7

Commits
-------

0f15099 Update to Symfony 3.3.9 and fix latest changes
sayjun0505 added a commit to sayjun0505/sym_proj that referenced this pull request Apr 16, 2023
This PR was squashed before being merged into the master branch (closes #648).

Discussion
----------

Update to Symfony 3.3.9 and fix latest changes

The [second commit][1] remove the unnecessary configuration for controllers services fixed in symfony/symfony#24126

The third commit update Symfony Flex deps and update `phpunit.xml.dist` env vars according to symfony/recipes#170 and symfony/flex#148

<details>
<summary>See "composer update" log trace.</summary>

```bash
Installing dependencies (including require-dev) from lock file
Package operations: 1 install, 45 updates, 0 removals
  - Updating composer/ca-bundle (1.0.7 => 1.0.8): Downloading (100%)
  - Updating symfony/doctrine-bridge (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/stopwatch (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/routing (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/http-foundation (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/event-dispatcher (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/debug (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/http-kernel (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/flex (v1.0.17 => v1.0.19): Downloading (100%)
  - Updating symfony/finder (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/filesystem (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dependency-injection (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/config (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/class-loader (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/cache (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/framework-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/console (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating doctrine/doctrine-fixtures-bundle (2.3.0 => v2.4.0): Downloading (100%)
  - Updating symfony/asset (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dom-crawler (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/browser-kit (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/css-selector (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/expression-language (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/inflector (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/property-access (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/options-resolver (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/intl (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/form (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/monolog-bridge (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/security (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/security-bundle (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/swiftmailer-bundle (v3.0.3 => v3.0.4): Downloading (100%)
  - Updating symfony/twig-bridge (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/twig-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/translation (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/validator (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/yaml (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/process (v3.3.8 => v3.3.9): Loading from cache
  - Installing composer/semver (1.4.2): Downloading (100%)
  - Updating friendsofphp/php-cs-fixer (v2.5.0 => v2.6.0): Downloading (100%)
  - Updating symfony/var-dumper (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/debug-bundle (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dotenv (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/phpunit-bridge (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/web-profiler-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/web-server-bundle (v3.3.8 => v3.3.9): Loading from cache
Generating autoload files
```
</details>

  [1]: symfony/demo@ba751c7

Commits
-------

0f15099 Update to Symfony 3.3.9 and fix latest changes
spider-yamet added a commit to spider-yamet/sym_proj that referenced this pull request Apr 16, 2023
This PR was squashed before being merged into the master branch (closes #648).

Discussion
----------

Update to Symfony 3.3.9 and fix latest changes

The [second commit][1] remove the unnecessary configuration for controllers services fixed in symfony/symfony#24126

The third commit update Symfony Flex deps and update `phpunit.xml.dist` env vars according to symfony/recipes#170 and symfony/flex#148

<details>
<summary>See "composer update" log trace.</summary>

```bash
Installing dependencies (including require-dev) from lock file
Package operations: 1 install, 45 updates, 0 removals
  - Updating composer/ca-bundle (1.0.7 => 1.0.8): Downloading (100%)
  - Updating symfony/doctrine-bridge (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/stopwatch (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/routing (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/http-foundation (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/event-dispatcher (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/debug (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/http-kernel (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/flex (v1.0.17 => v1.0.19): Downloading (100%)
  - Updating symfony/finder (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/filesystem (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dependency-injection (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/config (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/class-loader (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/cache (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/framework-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/console (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating doctrine/doctrine-fixtures-bundle (2.3.0 => v2.4.0): Downloading (100%)
  - Updating symfony/asset (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dom-crawler (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/browser-kit (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/css-selector (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/expression-language (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/inflector (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/property-access (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/options-resolver (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/intl (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/form (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/monolog-bridge (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/security (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/security-bundle (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/swiftmailer-bundle (v3.0.3 => v3.0.4): Downloading (100%)
  - Updating symfony/twig-bridge (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/twig-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/translation (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/validator (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/yaml (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/process (v3.3.8 => v3.3.9): Loading from cache
  - Installing composer/semver (1.4.2): Downloading (100%)
  - Updating friendsofphp/php-cs-fixer (v2.5.0 => v2.6.0): Downloading (100%)
  - Updating symfony/var-dumper (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/debug-bundle (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dotenv (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/phpunit-bridge (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/web-profiler-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/web-server-bundle (v3.3.8 => v3.3.9): Loading from cache
Generating autoload files
```
</details>

  [1]: symfony/demo@ba751c7

Commits
-------

0f15099 Update to Symfony 3.3.9 and fix latest changes
frederickboyd added a commit to frederickboyd/frederickboyd that referenced this pull request May 25, 2025
This PR was squashed before being merged into the master branch (closes #648).

Discussion
----------

Update to Symfony 3.3.9 and fix latest changes

The [second commit][1] remove the unnecessary configuration for controllers services fixed in symfony/symfony#24126

The third commit update Symfony Flex deps and update `phpunit.xml.dist` env vars according to symfony/recipes#170 and symfony/flex#148

<details>
<summary>See "composer update" log trace.</summary>

```bash
Installing dependencies (including require-dev) from lock file
Package operations: 1 install, 45 updates, 0 removals
  - Updating composer/ca-bundle (1.0.7 => 1.0.8): Downloading (100%)
  - Updating symfony/doctrine-bridge (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/stopwatch (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/routing (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/http-foundation (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/event-dispatcher (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/debug (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/http-kernel (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/flex (v1.0.17 => v1.0.19): Downloading (100%)
  - Updating symfony/finder (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/filesystem (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dependency-injection (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/config (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/class-loader (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/cache (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/framework-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/console (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating doctrine/doctrine-fixtures-bundle (2.3.0 => v2.4.0): Downloading (100%)
  - Updating symfony/asset (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dom-crawler (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/browser-kit (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/css-selector (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/expression-language (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/inflector (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/property-access (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/options-resolver (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/intl (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/form (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/monolog-bridge (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/security (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/security-bundle (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/swiftmailer-bundle (v3.0.3 => v3.0.4): Downloading (100%)
  - Updating symfony/twig-bridge (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/twig-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/translation (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/validator (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/yaml (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/process (v3.3.8 => v3.3.9): Loading from cache
  - Installing composer/semver (1.4.2): Downloading (100%)
  - Updating friendsofphp/php-cs-fixer (v2.5.0 => v2.6.0): Downloading (100%)
  - Updating symfony/var-dumper (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/debug-bundle (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dotenv (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/phpunit-bridge (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/web-profiler-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/web-server-bundle (v3.3.8 => v3.3.9): Loading from cache
Generating autoload files
```
</details>

  [1]: symfony/demo@ba751c7

Commits
-------

0f15099 Update to Symfony 3.3.9 and fix latest changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants