Skip to content

Make $uri protected #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make $uri protected #10

wants to merge 1 commit into from

Conversation

lenar
Copy link

@lenar lenar commented Mar 2, 2013

Now it's possible to pass the value to new instances in subclasses.

@lenar
Make $uri protected
ea54351 
Now it's possible to pass the value to new instances in subclasses.
@lenar
Copy link
Author

lenar commented Apr 16, 2013

This PR was created so one can extend the class and override any method doing new static with readily
available $uri value. Currently on has to override the constructor too and store it's own uri value to
make this kind of extending possible.
Comments?

@fabpot
Copy link
Member

fabpot commented Apr 21, 2013

fixed as of symfony/symfony#7211

@fabpot fabpot closed this Apr 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lenar @fabpot