Skip to content

ci: expose STRANDS_TEST_API_KEYS_SECRET_NAME to integration tests #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025

Conversation

dbschmigelski
Copy link
Member

@dbschmigelski dbschmigelski commented Jul 22, 2025

Description

Small PR as a prerequisite for #510. This will allow us to run the tests and verify before merging that the tests succeed.

Q: Why is this needed?
A: The integration test is running as a pull_request_target. This means the workflow that gets executed is the current one that is in main. The workflow in main does not set the STRANDS_TEST_API_KEYS_SECRET_NAME. However, STRANDS_TEST_API_KEYS_SECRET_NAME is needed by the code that is being tested, which is the cloned code from the fork. So, we need to either merge STRANDS_TEST_API_KEYS_SECRET_NAME first, or we need to optimistically merge based on testing outside of the PRs checks.

Related Issues

#510

Type of Change

Other (please describe): 2 phased change for #510

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • [N/A] I have added any necessary tests that prove my fix is effective or my feature works
  • [N/A] I have updated the documentation accordingly
  • [N/A] I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dbschmigelski
Copy link
Member Author

Linting is failing, need to merge in #508 with fix.

@dbschmigelski dbschmigelski merged commit 6905342 into strands-agents:main Jul 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants