Skip to content

fix(telemetry): group traces when using agent as tool in an agent #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

poshinchen
Copy link
Contributor

@poshinchen poshinchen commented Jul 18, 2025

Description

Fix tracing issue when using agent as tool in an agent

I've tested on langfuse and CW, need to add unit tests later on.

To-do: Add unit tests

Related Issues

#489

Documentation PR

N/A

Type of Change

Bug fix

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@poshinchen poshinchen requested a review from a team July 18, 2025 00:47
@poshinchen poshinchen force-pushed the fix/fix-tracing-in-agent-tool branch from eeba30b to 366573b Compare July 18, 2025 01:05
@poshinchen poshinchen marked this pull request as ready for review July 18, 2025 18:23
cagataycali
cagataycali previously approved these changes Jul 18, 2025
@poshinchen poshinchen merged commit 2c067b4 into strands-agents:main Jul 18, 2025
12 checks passed
dbschmigelski pushed a commit to Ketansuhaas/sdk-python that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants