Skip to content

chore: address commit comments for commit e711bd7 (issue #7613) #7633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2025
Merged

chore: address commit comments for commit e711bd7 (issue #7613) #7633

merged 3 commits into from
Jul 12, 2025

Conversation

anmolsah
Copy link
Contributor

Resolves #7613.

Description

What is the purpose of this pull request?

This pull request addresses a code review comment related to commit e711bd7, which suggested updating the benchmark label to follow stdlib's naming conventions.

✅ Changes made:

  • Updated the benchmark label from: 
    bench( pkg + '::native', opts, function benchmark( b ) {
    to: 
    bench( pkg+'::native', function benchmark( b ) {

This change aligns the benchmark format with stdlib’s conventions, improving consistency and clarity when profiling native vs factory vs wasm implementations.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No questions at the moment. Please let me know if anything needs further clarification.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

None.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Jul 12, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jul 12, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/pareto-type1/mean $\color{green}181/181$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}181/181$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Copy link
Member

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 12, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 12, 2025
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jul 12, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jul 12, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

chore: address commit comments for commit `e711bd7` (issue #7613)

PR-URL: https://github.com/stdlib-js/stdlib/pull/7633
Closes: https://github.com/stdlib-js/stdlib/issues/7613

Co-authored-by: Anmol Sah <kumarxxx242424@gmail.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 6bfa600 into stdlib-js:develop Jul 12, 2025
29 checks passed
@anmolsah anmolsah deleted the chore/address-commit-comments-e711bd7 branch July 12, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit e711bd7)
3 participants
@anmolsah @stdlib-bot @Planeshifter