Skip to content

chore: address commit comments for commit e6823fe (issue #7624) #7632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2025
Merged

chore: address commit comments for commit e6823fe (issue #7624) #7632

merged 1 commit into from
Jul 12, 2025

Conversation

anmolsah
Copy link
Contributor

@anmolsah anmolsah commented Jul 12, 2025 •
edited
Loading

Resolves #7624.

Description

What is the purpose of this pull request?

This pull request addresses a code review comment related to commit e6823fe, which suggested updating the benchmark label to follow stdlib's naming conventions.

✅ Changes made:

  • Updated the benchmark label from: 
    bench( pkg, function benchmark( b ) {
    to: 
    bench( pkg+'::native', function benchmark( b ) {

This improves clarity when running benchmark comparisons across native, factory, and wasm implementations.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No questions at the moment. Please let me know if anything else needs adjustment.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

None.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Jul 12, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/signrank/pdf $\color{red}358/360$
$\color{green}+99.44\%$ 		$\color{red}36/37$
$\color{green}+97.30\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{red}358/360$
$\color{green}+99.44\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jul 12, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jul 12, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

chore: address commit comments for commit `e6823fe` (issue #7624)

PR-URL: https://github.com/stdlib-js/stdlib/pull/7632
Closes: https://github.com/stdlib-js/stdlib/issues/7624

Co-authored-by: Anmol Sah <kumarxxx242424@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit a63b948 into stdlib-js:develop Jul 12, 2025
86 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit e6823fe)
3 participants
@anmolsah @stdlib-bot @Planeshifter