Skip to content

old svix version #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

old svix version #781

wants to merge 8 commits into from

Conversation

fomalhautb
Copy link
Contributor

@fomalhautb fomalhautb commented Jul 18, 2025


Important

Update Svix server version in Docker Compose and add delays in webhook functions to handle slow responses.

  • Docker Compose:
    • Update svix-server image to svix/svix-server:v1.69 in docker.compose.yaml.
  • Testing:
    • Add await wait(5000) in findWebhookAttempt() and listWebhookAttempts() in backend-helpers.ts to handle slow Svix responses.
    • Remove await wait(5000) from team-memberships.test.ts as it is now handled in backend-helpers.ts.

This description was created by Ellipsis for 5e361bb. You can customize this summary. It will automatically update as commits are pushed.

Copy link

vercel bot commented Jul 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stack-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2025 0:03am
stack-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2025 0:03am
stack-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2025 0:03am
stack-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2025 0:03am

Copy link

recurseml bot commented Jul 18, 2025

✨ No files to analyze in this PR.

Need help? Join our Discord for support!
https://discord.gg/qEjHQk64Z9

@fomalhautb fomalhautb closed this Jul 18, 2025
@fomalhautb fomalhautb force-pushed the fix-webhook-actions branch from 923c642 to c7f5e9c Compare July 18, 2025 18:11
@fomalhautb fomalhautb reopened this Jul 18, 2025
Copy link

recurseml bot commented Jul 18, 2025

✨ No issues found! Your code is sparkling clean! ✨

🗒️ View all ignored comments in this repo
  • The constraint 'TokenStoreType extends string' is too restrictive. It should likely be 'TokenStoreType extends string | object' to match the condition check in line 113 where TokenStoreType is checked against {}
  • Return type mismatch - the interface declares useUsers() returning ServerUser[] but the Team interface that this extends declares useUsers() returning TeamUser[]
  • There is a syntax error in the super constructor call due to the ellipsis operator used incorrectly. Objects aren't being merged correctly. This syntax usage can lead to runtime errors when trying to pass the merged object to 'super()'. Verify that the intended alterations to the object occur before or outside of the super() call if needed.
  • Throwing an error when no active span is found is too aggressive. The log function should gracefully fallback to console.log or another logging mechanism when there's no active span, since not all execution contexts will have an active span. This makes the code less resilient and could break functionality in non-traced environments.

📚 Relevant Docs

  • Function sets backendContext with a new configuration but doesn't pass 'defaultProjectKeys'. Since defaultProjectKeys is required in the type definition and cannot be updated (throws error if tried to set), this will cause a type error.
  • The schema is using array syntax for pick() which is incorrect for Yup schemas. The pick() method in Yup expects individual arguments, not an array. Should be changed to: emailConfigSchema.pick('type', 'host', 'port', 'username', 'sender_name', 'sender_email')

📚 Relevant Docs

  • Creating a refresh token with current timestamp as expiration means it expires immediately. Should set a future date for token expiration.
  • The 'tools' object is initialized as an empty object, even though 'tools' is presumably expected to contain tool definitions. This could cause the server capabilities to lack necessary tool configurations, thus potentially impacting functionalities that depend on certain tool setups.

📚 Relevant Docs

  • 'STACK_SECRET_SERVER_KEY' is potentially being included in every request header without checking its existence again here. Although it's checked during initialization, this could lead to security issues as it's exposed in all communications where the header is logged or captured.

📚 Relevant Docs

  • When adding 'use client' directive at the beginning, it doesn't check if file.text already contains the 'use client' directive. This could lead to duplicate 'use client' directives if the file already has one.

📚 Relevant Docs

Need help? Join our Discord for support!
https://discord.gg/qEjHQk64Z9

@fomalhautb fomalhautb closed this Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant