Template migrations #778

BilalG1 · 2025-07-18T00:28:19Z

Important

This PR adds functionality for migrating email templates and themes, including backend API endpoints and frontend UI components for managing the migration process.

Backend API:
- Adds POST and GET handlers in route.tsx for email template conversion, handling project-specific template migration.
- Implements convertHandlebarsToJSX and generateTsxSourceFromConfiguration in convert.tsx for transforming email templates.
- Updates route.tsx in email-themes to manage email themes, ensuring active theme consistency.
Frontend Components:
- Introduces page-client.tsx for managing template migration UI, including project ID retrieval and migration execution.
- Adds page.tsx to render the PageClient component.
Admin Interface:
- Extends admin-interface.ts with methods for fetching project IDs and converting email templates.
- Updates admin-app-impl.ts and admin-app.ts to include new migration methods and cache management.

^{This description was created by}^{for 871eda9. You can customize this summary. It will automatically update as commits are pushed.}

vercel · 2025-07-18T00:28:23Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
stack-backend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 18, 2025 1:23am
stack-dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 18, 2025 1:23am
stack-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 18, 2025 1:23am
stack-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 18, 2025 1:23am

greptile-apps

Greptile Summary

This PR implements a comprehensive email template migration system, transitioning from Handlebars-based templates to React-based components using @react-email/components. The changes include:

A new migration utility that converts Handlebars syntax to JSX
Internal API endpoints for template conversion
UI components for administrators to monitor and control the migration process
Enhanced type safety improvements across the codebase
Fallback mechanisms for email themes to ensure system stability during migration

The implementation allows for a controlled, project-by-project migration approach with proper error handling and progress tracking. The code is well-structured with clear separation between the migration utility, API endpoints, and UI components.

Confidence score: 4/5

This PR is generally safe to merge as it includes proper error handling and fallback mechanisms
The high score is due to comprehensive test coverage and careful handling of edge cases, only slightly reduced due to the complexity of template conversion
Key files needing attention:
- apps/backend/src/app/api/latest/internal/email-templates/temp/convert.tsx - Core conversion logic
- apps/backend/src/app/api/latest/internal/email-themes/route.tsx - Theme fallback mechanism

_{10 files reviewed, 10 comments}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-07-18T00:28:49Z

...src/app/(main)/(protected)/projects/[projectId]/internal/templates-migration/page-client.tsx

+      for (const projectId of projectIds) {
+        const result = await adminApp.convertEmailTemplates(projectId);
+        setMigrationResults(prev => [...prev, {
+          projectId,
+          templatesConverted: result.templates_converted,
+          totalTemplates: result.total_templates
+        }]);
+      }


style: Migration is sequential and could take a long time for many projects. Consider using Promise.all() or batching for parallel processing

greptile-apps · 2025-07-18T00:28:49Z

apps/backend/src/app/api/latest/internal/email-templates/temp/convert.tsx

+
+export function getTransformedTemplateMetadata(metadata: EmailTemplateMetadata) {
+  const variableNames = metadata.variables.map(v => v.name);
+  const configuration = metadata.defaultContent[2];


logic: Accessing defaultContent[2] directly is fragile. Add type checking or document the expected structure

greptile-apps · 2025-07-18T00:28:49Z

...src/app/(main)/(protected)/projects/[projectId]/internal/templates-migration/page-client.tsx

+    } catch (error) {
+      console.error("Error running migration:", error);
+    } finally {


logic: Error handling is too generic. Need to handle failed migrations individually and provide retry mechanism

greptile-apps · 2025-07-18T00:28:49Z

apps/dashboard/src/components/vibe-coding/chat-adapters.ts

@@ -67,10 +67,10 @@ export function createHistoryAdapter(
  return {
    async load() {
      const { messages } = await adminApp.listChatMessages(threadId);
-      return { messages } as ExportedMessageRepository;
+      return { messages } as unknown as ExportedMessageRepository;


style: Double type assertion (as unknown as) could mask potential type mismatches. Consider creating a proper type conversion function.

greptile-apps · 2025-07-18T00:28:50Z

apps/backend/src/app/api/latest/internal/email-templates/temp/convert.tsx

+${indent}    }}
+${indent}    target="_blank"
+${indent}  >


logic: target="_blank" links should include rel="noopener" for security

Suggested change

${indent} }}

${indent} target="_blank"

${indent} >

${indent} }}

${indent} target="_blank"

${indent} rel="noopener"

${indent} >

greptile-apps · 2025-07-18T00:28:50Z

...src/app/(main)/(protected)/projects/[projectId]/internal/templates-migration/page-client.tsx

+      const ids = await adminApp.getProjectIdsForTemplatesMigration();
+      setProjectIds(ids);
+    } catch (error) {
+      console.error("Error getting project IDs:", error);


logic: Error not displayed to user. Add error toast/alert for better UX

greptile-apps · 2025-07-18T00:28:50Z

apps/backend/src/app/api/latest/internal/email-themes/route.tsx

+      if (DEFAULT_EMAIL_THEME_ID in themeList) {
+        newActiveTheme = DEFAULT_EMAIL_THEME_ID;
+      } else {
+        newActiveTheme = Object.keys(themeList)[0];


logic: consider checking if themeList is empty before accessing index 0

greptile-apps · 2025-07-18T00:28:50Z

apps/dashboard/src/components/vibe-coding/chat-adapters.ts

    },
    async append(message) {
-      await adminApp.saveChatMessage(threadId, message);
+      await adminApp.saveChatMessage(threadId, message as unknown as ChatMessage);


logic: Use type guard or validation before casting to ChatMessage to ensure message has required structure

greptile-apps · 2025-07-18T00:28:51Z

apps/backend/src/app/api/latest/internal/email-templates/temp/[projectId]/route.tsx

+      const templateMetadata = {
+        ...defaultTemplateMetadata,
+        defaultContent: {
+          [2]: template.content,


style: Magic number '2' used for content version - consider defining this as a constant with documentation on its significance

greptile-apps · 2025-07-18T00:28:51Z

apps/backend/src/app/api/latest/internal/email-templates/temp/[projectId]/route.tsx

+          [2]: template.content,
+        },
+      };
+      emailTemplates[configTemplateId] = getTransformedTemplateMetadata(templateMetadata as unknown as EmailTemplateMetadata);


style: Type assertion to unknown then EmailTemplateMetadata suggests potential type mismatch - consider restructuring to avoid unsafe type casting

recurseml · 2025-07-18T00:29:35Z

apps/backend/src/app/api/latest/internal/email-themes/route.tsx

+      if (DEFAULT_EMAIL_THEME_ID in themeList) {
+        newActiveTheme = DEFAULT_EMAIL_THEME_ID;
+      } else {
+        newActiveTheme = Object.keys(themeList)[0];


The code assumes themeList has at least one entry when falling back to Object.keys(themeList)[0]. If themeList is empty, this will assign undefined to newActiveTheme, which will cause a runtime error when used as a configuration value. The code should validate that themeList is not empty before accessing the first key.

Suggested change

newActiveTheme = Object.keys(themeList)[0];

newActiveTheme = Object.keys(themeList).length > 0 ? Object.keys(themeList)[0] : DEFAULT_EMAIL_THEME_ID;

React with 👍 to tell me that this comment was useful, or 👎 if not (and I'll stop posting more comments like this in the future)

recurseml · 2025-07-18T00:29:37Z

😱 Found 1 issue. Time to roll up your sleeves! 😱

🗒️ View all ignored comments in this repo

The constraint 'TokenStoreType extends string' is too restrictive. It should likely be 'TokenStoreType extends string | object' to match the condition check in line 113 where TokenStoreType is checked against {}
Return type mismatch - the interface declares useUsers() returning ServerUser[] but the Team interface that this extends declares useUsers() returning TeamUser[]
There is a syntax error in the super constructor call due to the ellipsis operator used incorrectly. Objects aren't being merged correctly. This syntax usage can lead to runtime errors when trying to pass the merged object to 'super()'. Verify that the intended alterations to the object occur before or outside of the super() call if needed.
Throwing an error when no active span is found is too aggressive. The log function should gracefully fallback to console.log or another logging mechanism when there's no active span, since not all execution contexts will have an active span. This makes the code less resilient and could break functionality in non-traced environments.

📚 Relevant Docs

Function sets backendContext with a new configuration but doesn't pass 'defaultProjectKeys'. Since defaultProjectKeys is required in the type definition and cannot be updated (throws error if tried to set), this will cause a type error.
The schema is using array syntax for pick() which is incorrect for Yup schemas. The pick() method in Yup expects individual arguments, not an array. Should be changed to: emailConfigSchema.pick('type', 'host', 'port', 'username', 'sender_name', 'sender_email')

📚 Relevant Docs

Creating a refresh token with current timestamp as expiration means it expires immediately. Should set a future date for token expiration.
The 'tools' object is initialized as an empty object, even though 'tools' is presumably expected to contain tool definitions. This could cause the server capabilities to lack necessary tool configurations, thus potentially impacting functionalities that depend on certain tool setups.

📚 Relevant Docs

'STACK_SECRET_SERVER_KEY' is potentially being included in every request header without checking its existence again here. Although it's checked during initialization, this could lead to security issues as it's exposed in all communications where the header is logged or captured.

📚 Relevant Docs

When adding 'use client' directive at the beginning, it doesn't check if file.text already contains the 'use client' directive. This could lead to duplicate 'use client' directives if the file already has one.

📚 Relevant Docs

⚠️ Only 5 files were analyzed due to processing limits.

^{Need help? Join our Discord for support!
https://discord.gg/qEjHQk64Z9}

ellipsis-dev · 2025-07-18T00:30:28Z

apps/dashboard/src/components/vibe-coding/chat-adapters.ts

@@ -67,10 +67,10 @@ export function createHistoryAdapter(
  return {
    async load() {
      const { messages } = await adminApp.listChatMessages(threadId);
-      return { messages } as ExportedMessageRepository;
+      return { messages } as unknown as ExportedMessageRepository;


Avoid casting with 'as unknown as ...' in type conversions; define proper types to ensure type safety for message repositories and chat messages.

ellipsis-dev · 2025-07-18T00:30:28Z

packages/template/src/lib/stack-app/apps/interfaces/admin-app.ts

    updateNewEmailTemplate(id: string, tsxSource: string): Promise<{ renderedHtml: string }>,
+
+    getProjectIdsForTemplatesMigration(): Promise<string[]>,


Remember to add end-to-end tests for new backend endpoints (e.g. email templates migration and theme endpoints) to cover the updated behavior.

^{This comment was generated because it violated a code review rule: mrule_PmPnAQVEfJISxhHC.}

BilalG1 added 6 commits July 17, 2025 17:27

branded type for chat message

35e507d

fix unknown theme error

68365c2

fix

548f81a

handle missing default theme

6384b77

templates migration route and dashboard page

1c7e662

fix import

ac660b2

github-actions bot assigned BilalG1 Jul 18, 2025

greptile-apps bot reviewed Jul 18, 2025

View reviewed changes

recurseml bot reviewed Jul 18, 2025

View reviewed changes

ellipsis-dev bot reviewed Jul 18, 2025

View reviewed changes

BilalG1 changed the title ~~Template migrations bg~~ Template migrations Jul 18, 2025

remove as const

871eda9

BilalG1 closed this Jul 18, 2025

	newActiveTheme = Object.keys(themeList)[0];
	newActiveTheme = Object.keys(themeList).length > 0 ? Object.keys(themeList)[0] : DEFAULT_EMAIL_THEME_ID;

		updateNewEmailTemplate(id: string, tsxSource: string): Promise<{ renderedHtml: string }>,

		getProjectIdsForTemplatesMigration(): Promise<string[]>,

Template migrations #778

Template migrations #778

Conversation

BilalG1 commented Jul 18, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Greptile Summary

Confidence score: 4/5

Uh oh!

greptile-apps bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

recurseml bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

recurseml bot commented Jul 18, 2025

Uh oh!

ellipsis-dev bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BilalG1 commented Jul 18, 2025 •

edited by ellipsis-dev bot

Loading

vercel bot commented Jul 18, 2025 •

edited

Loading