Skip to content

fix unknown theme error #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

fix unknown theme error #773

wants to merge 7 commits into from

Conversation

BilalG1
Copy link
Contributor

@BilalG1 BilalG1 commented Jul 16, 2025


Important

Fixes unknown theme error by setting a default theme if the current theme is not found in route.tsx.

  • Behavior:
    • In GET handler of route.tsx, checks if currentActiveTheme exists in themeList. If not, sets newActiveTheme to DEFAULT_EMAIL_THEME_ID or first theme in list.
    • Updates environment config with overrideEnvironmentConfigOverride() to set new active theme.
  • Imports:
    • Adds DEFAULT_EMAIL_THEME_ID import to route.tsx.

This description was created by Ellipsis for 4b629d4. You can customize this summary. It will automatically update as commits are pushed.

Copy link

vercel bot commented Jul 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stack-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2025 11:41am
stack-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2025 11:41am
stack-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2025 11:41am
stack-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2025 11:41am

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR implements a defensive fix for email theme handling in the backend API. It addresses a potential issue where the system could reference a non-existent email theme, which could lead to runtime errors. The changes add validation logic that checks if the currently active theme exists in the available theme list. If an invalid theme is detected, the system automatically falls back to a default theme using the overrideEnvironmentConfigOverride function.

This change fits well with the existing email management infrastructure (as seen in the /internal/emails and /email-templates directories) by ensuring configuration stability and preventing potential service disruptions.

Confidence score: 4/5

  1. This PR is safe to merge as it adds defensive programming without modifying core functionality
  2. High confidence due to the simplicity of the change and clear fallback behavior
  3. Files needing attention:
    • apps/backend/src/app/api/latest/internal/email-themes/route.tsx - verify the DEFAULT_EMAIL_THEME_ID constant is properly defined

1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile

Copy link

recurseml bot commented Jul 16, 2025

✨ No issues found! Your code is sparkling clean! ✨

🗒️ View all ignored comments in this repo
  • The constraint 'TokenStoreType extends string' is too restrictive. It should likely be 'TokenStoreType extends string | object' to match the condition check in line 113 where TokenStoreType is checked against {}
  • Return type mismatch - the interface declares useUsers() returning ServerUser[] but the Team interface that this extends declares useUsers() returning TeamUser[]
  • There is a syntax error in the super constructor call due to the ellipsis operator used incorrectly. Objects aren't being merged correctly. This syntax usage can lead to runtime errors when trying to pass the merged object to 'super()'. Verify that the intended alterations to the object occur before or outside of the super() call if needed.
  • Throwing an error when no active span is found is too aggressive. The log function should gracefully fallback to console.log or another logging mechanism when there's no active span, since not all execution contexts will have an active span. This makes the code less resilient and could break functionality in non-traced environments.

📚 Relevant Docs

  • Function sets backendContext with a new configuration but doesn't pass 'defaultProjectKeys'. Since defaultProjectKeys is required in the type definition and cannot be updated (throws error if tried to set), this will cause a type error.
  • The schema is using array syntax for pick() which is incorrect for Yup schemas. The pick() method in Yup expects individual arguments, not an array. Should be changed to: emailConfigSchema.pick('type', 'host', 'port', 'username', 'sender_name', 'sender_email')

📚 Relevant Docs

  • Creating a refresh token with current timestamp as expiration means it expires immediately. Should set a future date for token expiration.
  • The 'tools' object is initialized as an empty object, even though 'tools' is presumably expected to contain tool definitions. This could cause the server capabilities to lack necessary tool configurations, thus potentially impacting functionalities that depend on certain tool setups.

📚 Relevant Docs

  • 'STACK_SECRET_SERVER_KEY' is potentially being included in every request header without checking its existence again here. Although it's checked during initialization, this could lead to security issues as it's exposed in all communications where the header is logged or captured.

📚 Relevant Docs

  • When adding 'use client' directive at the beginning, it doesn't check if file.text already contains the 'use client' directive. This could lead to duplicate 'use client' directives if the file already has one.

📚 Relevant Docs

Need help? Join our Discord for support!
https://discord.gg/qEjHQk64Z9

@BilalG1 BilalG1 assigned N2D4 and unassigned BilalG1 Jul 16, 2025
Copy link
Contributor

@N2D4 N2D4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also get rid of the string default-light everywhere, rename it to Default Light, and not use display names as identifiers anywhere?

@N2D4 N2D4 assigned BilalG1 and unassigned N2D4 Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants