-
Notifications
You must be signed in to change notification settings - Fork 428
Fix source of truth for custom schemas #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR modifies the E2E API test workflow configuration to establish a dedicated database schema for source of truth testing. The key changes involve:
- Setting up a new database connection string pointing to 'source-of-truth-db' with a specific 'sot-schema'
- Updating the environment variables and migration commands to use this new connection
This change improves test isolation and makes the testing environment more maintainable by separating source of truth testing from other test scenarios.
Confidence score: 4.5/5
- This PR is very safe to merge as it only affects test infrastructure
- The changes are well-isolated, only touching test configuration, and follow good database practice for test isolation
- Files needing attention:
- .github/workflows/e2e-source-of-truth-api-tests.yaml - Verify the connection string format and credentials are correct
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
✨ No issues found! Your code is sparkling clean! ✨ 🗒️ View all ignored comments in this repo
Need help? Join our Discord for support! |
Important
Fixes handling of custom schemas by updating connection strings, SQL queries, and removing obsolete triggers and functions.
.github/workflows/e2e-source-of-truth-api-tests.yaml
to include?schema=sot-schema
.getPrismaSchemaForTenancy
andgetPrismaSchemaForSourceOfTruth
functions inprisma-client.tsx
to retrieve schema names.sqlQuoteIdent(schema)
for schema-specific SQL queries incrud.tsx
files.project_user_insert_trigger
,project_user_update_trigger
,project_user_delete_trigger
inmigration.sql
.update_project_user_count()
inmigration.sql
.sqlQuoteIdent()
function inprisma-client.tsx
to safely quote identifiers.This description was created by
for 0923173. You can customize this summary. It will automatically update as commits are pushed.