Skip to content

[Docs] posthog Integration #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 14, 2025
Merged

[Docs] posthog Integration #761

merged 9 commits into from
Jul 14, 2025

Conversation

madster456
Copy link
Collaborator

@madster456 madster456 commented Jul 11, 2025


Important

Integrates PostHog for page view tracking in the documentation site with necessary rewrites and components.

  • Integration:
    • Adds PostHog integration to track page views in layout.tsx using PostHogPageView and CSPostHogProvider.
    • Adds posthog-js to package.json dependencies.
  • Rewrites:
    • Adds proxy rewrites in next.config.mjs to prevent ad blockers from blocking PostHog requests.
  • Components:
    • Creates PostHogPageView in pageview.tsx and pageview-dynamic.tsx to capture page views.
    • Implements CSPostHogProvider in posthog-provider.tsx to initialize PostHog with specific settings.

This description was created by Ellipsis for 5551f4f. You can customize this summary. It will automatically update as commits are pushed.

Copy link

vercel bot commented Jul 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stack-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 6:28pm
stack-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 6:28pm
stack-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 6:28pm
stack-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 6:28pm

@madster456 madster456 changed the title posthog init posthog Integration Jul 11, 2025
@madster456 madster456 changed the title posthog Integration [Docs] posthog Integration Jul 11, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added PostHog analytics integration to the docs site with several implementation concerns that need addressing.

  • Hardcoded PostHog key in docs/src/components/posthog-provider.tsx should be moved to environment variables for security and flexibility
  • Missing critical security configurations for input masking that exist in main app, potentially exposing sensitive data
  • Weak validation check for PostHog key (length > 5) in provider component needs stronger validation
  • Development artifacts (console.log statements) left in production code
  • Consider using Map instead of plain objects in pageview tracking to prevent potential prototype pollution vulnerabilities

5 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile

Copy link

recurseml bot commented Jul 11, 2025

😱 Found 1 issue. Time to roll up your sleeves! 😱

🗒️ View all ignored comments in this repo
  • The constraint 'TokenStoreType extends string' is too restrictive. It should likely be 'TokenStoreType extends string | object' to match the condition check in line 113 where TokenStoreType is checked against {}
  • Return type mismatch - the interface declares useUsers() returning ServerUser[] but the Team interface that this extends declares useUsers() returning TeamUser[]
  • There is a syntax error in the super constructor call due to the ellipsis operator used incorrectly. Objects aren't being merged correctly. This syntax usage can lead to runtime errors when trying to pass the merged object to 'super()'. Verify that the intended alterations to the object occur before or outside of the super() call if needed.
  • Throwing an error when no active span is found is too aggressive. The log function should gracefully fallback to console.log or another logging mechanism when there's no active span, since not all execution contexts will have an active span. This makes the code less resilient and could break functionality in non-traced environments.

📚 Relevant Docs

  • Function sets backendContext with a new configuration but doesn't pass 'defaultProjectKeys'. Since defaultProjectKeys is required in the type definition and cannot be updated (throws error if tried to set), this will cause a type error.
  • The schema is using array syntax for pick() which is incorrect for Yup schemas. The pick() method in Yup expects individual arguments, not an array. Should be changed to: emailConfigSchema.pick('type', 'host', 'port', 'username', 'sender_name', 'sender_email')

📚 Relevant Docs

  • Creating a refresh token with current timestamp as expiration means it expires immediately. Should set a future date for token expiration.
  • The 'tools' object is initialized as an empty object, even though 'tools' is presumably expected to contain tool definitions. This could cause the server capabilities to lack necessary tool configurations, thus potentially impacting functionalities that depend on certain tool setups.

📚 Relevant Docs

  • 'STACK_SECRET_SERVER_KEY' is potentially being included in every request header without checking its existence again here. Although it's checked during initialization, this could lead to security issues as it's exposed in all communications where the header is logged or captured.

📚 Relevant Docs

  • When adding 'use client' directive at the beginning, it doesn't check if file.text already contains the 'use client' directive. This could lead to duplicate 'use client' directives if the file already has one.

📚 Relevant Docs

Need help? Join our Discord for support!
https://discord.gg/qEjHQk64Z9

@N2D4 N2D4 removed their assignment Jul 11, 2025
@madster456 madster456 merged commit c93086c into dev Jul 14, 2025
17 of 18 checks passed
@madster456 madster456 deleted the posthog_integration branch July 14, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants