Added entityName prop for custom labels #700

A-Vamshi · 2025-06-01T10:41:13Z

This PR adds the entityName prop to the following components/pages as requested in #655 issue.

selected-team-settings
account-settings
team-creation

While this addresses part of the issue, it's not a complete solution. Fully supporting this feature would likely require a broader change to the use of "team" terminology across the codebase.

I'm happy to take on this larger refactor if the maintainers agree it's the right direction.

Important

Adds entityName prop for customizable labels in AccountSettings, TeamCreation, and SelectedTeamSwitcher, using pluralize for plural forms.

Behavior:
- Adds entityName prop to AccountSettings, TeamCreation, and SelectedTeamSwitcher components for customizable labels.
- Defaults to "Team" if entityName is not provided.
- Uses pluralize for handling plural forms of entityName.
Dependencies:
- Adds pluralize to devDependencies in package.json and packages/template/package.json.
Misc:
- Updates various UI text elements to use entityName in account-settings.tsx, team-creation.tsx, and selected-team-switcher.tsx.

^{This description was created by}^{for 763fff6. You can customize this summary. It will automatically update as commits are pushed.}

…am-creation pages

vercel · 2025-06-01T10:41:18Z

Someone is attempting to deploy a commit to the Stack Team on Vercel.

A member of the Team first needs to authorize it.

CLAassistant · 2025-06-01T10:41:18Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ A-Vamshi
❌ Vamshi Adimalla

Vamshi Adimalla seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

recurseml · 2025-06-01T10:42:18Z

✨ No issues found! Your code is sparkling clean! ✨

🗒️ View all ignored comments in this repo

The constraint 'TokenStoreType extends string' is too restrictive. It should likely be 'TokenStoreType extends string | object' to match the condition check in line 113 where TokenStoreType is checked against {}
Return type mismatch - the interface declares useUsers() returning ServerUser[] but the Team interface that this extends declares useUsers() returning TeamUser[]
There is a syntax error in the super constructor call due to the ellipsis operator used incorrectly. Objects aren't being merged correctly. This syntax usage can lead to runtime errors when trying to pass the merged object to 'super()'. Verify that the intended alterations to the object occur before or outside of the super() call if needed.
Throwing an error when no active span is found is too aggressive. The log function should gracefully fallback to console.log or another logging mechanism when there's no active span, since not all execution contexts will have an active span. This makes the code less resilient and could break functionality in non-traced environments.

📚 Relevant Docs

Function sets backendContext with a new configuration but doesn't pass 'defaultProjectKeys'. Since defaultProjectKeys is required in the type definition and cannot be updated (throws error if tried to set), this will cause a type error.
The schema is using array syntax for pick() which is incorrect for Yup schemas. The pick() method in Yup expects individual arguments, not an array. Should be changed to: emailConfigSchema.pick('type', 'host', 'port', 'username', 'sender_name', 'sender_email')

📚 Relevant Docs

Creating a refresh token with current timestamp as expiration means it expires immediately. Should set a future date for token expiration.
The 'tools' object is initialized as an empty object, even though 'tools' is presumably expected to contain tool definitions. This could cause the server capabilities to lack necessary tool configurations, thus potentially impacting functionalities that depend on certain tool setups.

📚 Relevant Docs

'STACK_SECRET_SERVER_KEY' is potentially being included in every request header without checking its existence again here. Although it's checked during initialization, this could lead to security issues as it's exposed in all communications where the header is logged or captured.

📚 Relevant Docs

When adding 'use client' directive at the beginning, it doesn't check if file.text already contains the 'use client' directive. This could lead to duplicate 'use client' directives if the file already has one.

📚 Relevant Docs

greptile-apps

PR Summary

Added entityName prop to multiple components to allow customization of 'Team' terminology to other terms like 'Course', addressing issue #655's request for label customization.

Added entityName prop with default 'Team' to TeamCreation, AccountSettings, and SelectedTeamSwitcher components
Integrated pluralize package for proper handling of singular/plural entity names
Updated validation messages and UI labels to use the custom entity name
Note: URL paths and component IDs still use 'team' terminology, which may need addressing in a broader refactor

_{💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!}

_{5 file(s) reviewed, 6 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-06-01T10:41:46Z

packages/template/src/components-page/team-creation.tsx


  const schema = yupObject({
-    displayName: yupString().defined().nonEmpty(t('Please enter a team name')),
+    displayName: yupString().defined().nonEmpty(t(`Please enter ${entityName.toLowerCase()} name`)),


logic: Translation string with interpolation should use a translation key instead of direct interpolation to support proper localization

greptile-apps · 2025-06-01T10:41:48Z

packages/template/src/components-page/account-settings.tsx

              icon: <Icon name="CirclePlus"/>,
              type: 'item',
-              id: 'team-creation',
+              id: `team-creation`,


logic: ID still uses hardcoded 'team-creation' instead of entityName like other IDs

packages/template/src/components-page/account-settings.tsx

greptile-apps · 2025-06-01T10:41:49Z

packages/template/src/components-page/account-settings.tsx

@@ -101,7 +104,7 @@ export function AccountSettings(props: {
              content: item.content,
            } as const)) || []),
            ...(teams.length > 0 || project.config.clientTeamCreationEnabled) ? [{
-              title: t('Teams'),
+              title: t(`${pluralize(entityName)}`),


logic: t() call with template literal could cause translation issues. Consider using t('plural_entity', {entity: entityName})

Suggested change

title: t(`${pluralize(entityName)}`),

title: t('plural_entity', { entity: entityName }),

greptile-apps · 2025-06-01T10:42:12Z

packages/template/src/components/selected-team-switcher.tsx

      </SelectTrigger>
      <SelectContent className="stack-scope">
        {user?.selectedTeam ? <SelectGroup>
          <SelectLabel>
            <div className="flex items-center justify-between">
              <span>
-                {t('Current team')}
+                {t(`Current ${entityName.toLowerCase()}`)}
              </span>
              <Button variant='ghost' size='icon' className="h-6 w-6" onClick={() => navigate(`${app.urls.accountSettings}#team-${user.selectedTeam?.id}`)}>


logic: URL path still uses hardcoded 'team-' prefix in #team-${user.selectedTeam?.id}. Should use entityName for consistency.

greptile-apps · 2025-06-01T10:42:13Z

packages/template/src/components/selected-team-switcher.tsx

      </SelectTrigger>
      <SelectContent className="stack-scope">
        {user?.selectedTeam ? <SelectGroup>
          <SelectLabel>
            <div className="flex items-center justify-between">
              <span>
-                {t('Current team')}
+                {t(`Current ${entityName.toLowerCase()}`)}


style: Translation key uses string interpolation which may not work with all translation systems. Consider using a mapping of fixed keys instead.

patched-codes · 2025-06-01T10:44:11Z

Documentation Changes Required

1. docs/fern/docs/pages-template/components/account-settings.mdx

Add the following prop to the Props section, between fullPage and extraItems:

- `entityName` (optional): `string` - Custom name to use instead of "Team" for the team entities. The plural form will be automatically generated.

2. docs/fern/docs/pages-template/components/selected-team-switcher.mdx

Add the following prop to the Props section:

- `entityName` (optional): `string` - Used to customize the entity type name (defaults to 'Team')

Add a new 'Custom Entity Example' section showing how to use the component with a different entity type (e.g., Organization)
Update documentation to reflect that labels like 'Select team', 'Current team', 'Other teams' will change based on the entityName prop

3. docs/fern/docs/pages-template/sdk/types/project.mdx

No changes needed to this file. The changes in the TeamCreation component are UI-related customizations that don't affect the core functionality described in the documentation.

Please ensure these changes are reflected in the relevant documentation files.

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

N2D4

Thanks for the contribution! Just one comment, all occurences like t(`abc ${def} ghi`) must be like t(`abc {myvar1} ghi`, { myvar1: def }), or it'll break translation

N2D4 · 2025-07-09T18:42:43Z

~~Also, can you please sign the CLA?~~

nevermind, just saw you already signed on your other account

A-Vamshi · 2025-07-10T05:48:41Z

I'll be making another PR soon after making these changes "t(abc {myvar1} ghi, { myvar1: def })" as requested.

A-Vamshi · 2025-07-12T13:48:25Z

Just made the new PR here: #762

Added entityName prop in selected-team-settings, account-settings, te…

763fff6

…am-creation pages

greptile-apps bot reviewed Jun 1, 2025

View reviewed changes

Update packages/template/src/components-page/account-settings.tsx

d5e7e5b

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

N2D4 requested changes Jul 1, 2025

View reviewed changes

N2D4 assigned A-Vamshi Jul 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added entityName prop for custom labels #700

Added entityName prop for custom labels #700

Uh oh!

A-Vamshi commented Jun 1, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

vercel bot commented Jun 1, 2025

Uh oh!

CLAassistant commented Jun 1, 2025 •

edited

Loading

Uh oh!

recurseml bot commented Jun 1, 2025

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Jun 1, 2025

Uh oh!

greptile-apps bot Jun 1, 2025

Uh oh!

Uh oh!

greptile-apps bot Jun 1, 2025

Uh oh!

greptile-apps bot Jun 1, 2025

Uh oh!

greptile-apps bot Jun 1, 2025

Uh oh!

patched-codes bot commented Jun 1, 2025

Uh oh!

N2D4 left a comment

Uh oh!

N2D4 commented Jul 9, 2025 •

edited

Loading

Uh oh!

A-Vamshi commented Jul 10, 2025

Uh oh!

A-Vamshi commented Jul 12, 2025

Uh oh!

Uh oh!

	title: t(`${pluralize(entityName)}`),
	title: t('plural_entity', { entity: entityName }),

Added entityName prop for custom labels #700

Are you sure you want to change the base?

Added entityName prop for custom labels #700

Uh oh!

Conversation

A-Vamshi commented Jun 1, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Jun 1, 2025

Uh oh!

CLAassistant commented Jun 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

recurseml bot commented Jun 1, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

greptile-apps bot Jun 1, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps bot Jun 1, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 1, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 1, 2025

Choose a reason for hiding this comment

Uh oh!

patched-codes bot commented Jun 1, 2025

Documentation Changes Required

1. docs/fern/docs/pages-template/components/account-settings.mdx

2. docs/fern/docs/pages-template/components/selected-team-switcher.mdx

3. docs/fern/docs/pages-template/sdk/types/project.mdx

Uh oh!

N2D4 left a comment

Choose a reason for hiding this comment

Uh oh!

N2D4 commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

A-Vamshi commented Jul 10, 2025

Uh oh!

A-Vamshi commented Jul 12, 2025

Uh oh!

Uh oh!

A-Vamshi commented Jun 1, 2025 •

edited by ellipsis-dev bot

Loading

CLAassistant commented Jun 1, 2025 •

edited

Loading

N2D4 commented Jul 9, 2025 •

edited

Loading