Add support for EXTRACT function in Postgres v14 Upgrade #1243
Conversation
|
Sorry for the delay in reviewing. I have been traveling and did not see this PR. It seems given that |
Sounds good, just made some changes about that |
| sb.append(", "); | ||
| } | ||
|
|
||
| if (args[i].getExpressionType() == PostgresDataType.TIME |
There was a problem hiding this comment.
Why is this logic necessary? I don't really understand, so perhaps extracting this to a method that explains its purpose would be helpful.
| PostgresExpression[] args = randomFunction.getArguments(type, this, depth + 1); | ||
|
|
||
| // Create the appropriate function type based on the function name | ||
| if (randomFunction.getName().equals("extract")) { |
There was a problem hiding this comment.
Can we reference the enum here? Checking for hard-coded strings like extract is a somewhat error-prone pattern.
Closes #1242