Performance improvement for updating or deleting input #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganknecht
reviewed
Feb 25, 2019
| @@ -16,8 +16,6 @@ | |||
| from __future__ import absolute_import | |||
| from __future__ import print_function | |||
|
|
|||
| import unittest2 | |||
|
|
|||
loganknecht
approved these changes
Feb 25, 2019
| @@ -463,6 +463,13 @@ def info(self): | |||
| response = self.get("/services/server/info") | |||
| return _filter_content(_load_atom(response, MATCH_ENTRY_CONTENT)) | |||
|
|
|||
| def input(self, path, kind=None): | |||
There was a problem hiding this comment.
Not a big deal, but should we follow Go style practices of adding a new prefix to the declaration?
Like this
def new_input(self, path, kind=None):.
There was a problem hiding this comment.
not if we want consistency, so I'm going to say let's not do that here
loganknecht
approved these changes
Feb 25, 2019
|
|
||
| :return: A :class:`Input` object. | ||
| """ | ||
| return Input(self, path, kind=kind).refresh() |
There was a problem hiding this comment.
Non-blocking Personal Opinion: I like to see these operations broken down atomically because it makes things easier to debug.
new_input = Input(self, path, kind=kind)
new_input.refresh()
return new_input
There was a problem hiding this comment.
fair, I'm just following the style I used for job()
shilpabijam
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #168