Skip to content

Import module relatively #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

liketic
Copy link
Contributor

@liketic liketic commented Nov 2, 2016

I thinks it's a good practise to import internal modules consistently. Now we used relative and absolute import both.

@liketic
Copy link
Contributor Author

liketic commented Nov 7, 2016

The test failure is caused by test environment issue. @shakeelmohamed Could you please take a review at this PR? It's important to us. Happy to hear your comments. Thanks a lot.

@wjo1212
Copy link

wjo1212 commented Dec 1, 2016

dears, would you please merge the fixing? Thanks!

@liketic
Copy link
Contributor Author

liketic commented Dec 13, 2016

Hi @shakeelmohamed ,

Please let me know if you have any other concern. Thanks.

@shakeelmohamed
Copy link
Contributor

Closed in favor of #167, we just need to run some manual tests with modular inputs and custom search commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants