Skip to content

Fix py37 changes #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2017
Merged

Conversation

tacaswell
Copy link
Contributor

python/cpython#46 or bpo-29463 added docstring as a property to the module class that comes out of AST (so the free strings no longer appear an the first element in the parsed files).

@tacaswell
Copy link
Contributor Author

Will collide with #263

@QuLogic
Copy link
Contributor

QuLogic commented Aug 1, 2017

#263 is merged now.

python/cpython#46 or bpo-29463

added docstring as a property to the module class that comes out of
AST (so the free strings no longer appear an the first element in the
parsed files).
@tacaswell
Copy link
Contributor Author

The 2.7 failure is download related, not sure why nightly is not working....

@larsoner
Copy link
Contributor

larsoner commented Aug 5, 2017

LGTM

@choldgraf choldgraf merged commit 24b8886 into sphinx-gallery:master Aug 6, 2017
@choldgraf
Copy link
Contributor

this looks good to me as well - thanks @tacaswell for helping put out this tiny-ish fire before it became a big-ish fire :-)

@tacaswell tacaswell deleted the fix_py37_changes branch August 6, 2017 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants