This repository was archived by the owner on Dec 26, 2024. It is now read-only.
fix error handling edge case #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvayngrib
force-pushed
the
fixTxByHash
branch
from
f7bcf7b to
e21cf8b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you can reproduce the error by going here: https://api.etherscan.io/api?module=proxy&action=eth_getTransactionByHash&apiKey=ropsten&hash=0x341a97b957f7f454dcc8a231a837048e9e798e03c7e1d98e11a657a12b5d98e0
the
hashquery param should betxhash, and as you see the error is non-standard (error object vs status):{"jsonrpc":"2.0","error":{"code":-32602,"message":"Invalid params: expected a hex-encoded hash with 0x prefix."},"id":1}