Skip to content

ENH Enables common test for bicluster estimators #19542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2021
Merged

ENH Enables common test for bicluster estimators #19542

merged 2 commits into from
Feb 25, 2021

Conversation

thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Feb 24, 2021 •
edited by ogrisel
Loading

Adds bicluster modules back into common test using xfail for test that are failing.

jnothman
jnothman approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we subsequently open an issue?

@thomasjpfan thomasjpfan mentioned this pull request Feb 24, 2021
Open
7 tasks
@cmarmo cmarmo added module:test-suite everything related to our tests No Changelog Needed labels Feb 24, 2021
ogrisel
ogrisel approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ogrisel ogrisel merged commit 94abe05 into scikit-learn:main Feb 25, 2021
@ogrisel
Copy link
Member

ogrisel commented Feb 25, 2021

I expanded the issue a bit to give some guidelines to prospective contributors.

@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
module:cluster module:test-suite everything related to our tests No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasjpfan @ogrisel @jnothman @cmarmo