Skip to content

API deprecate plot_det_curve in favor of display class methods #19278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 6, 2021
Merged

API deprecate plot_det_curve in favor of display class methods #19278

merged 11 commits into from
Aug 6, 2021

Conversation

glemaitre
Copy link
Member

Address some of #15880

Create 2 class methods from_estimator and from_predictions to build the plot for the DET curve.

@glemaitre glemaitre marked this pull request as draft January 26, 2021 10:48
@glemaitre glemaitre marked this pull request as ready for review January 27, 2021 09:42
@glemaitre glemaitre changed the title API deprecate plot_det_curve in favor of class methods in diplay API deprecate plot_det_curve in favor of class methods in display Jan 28, 2021
@thomasjpfan thomasjpfan self-requested a review July 6, 2021 17:23
@glemaitre glemaitre mentioned this pull request Jul 19, 2021
Closed
5 tasks
thomasjpfan
thomasjpfan approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rth
rth approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rth rth changed the title API deprecate plot_det_curve in favor of class methods in display API deprecate plot_det_curve in favor of display class methods Aug 6, 2021
@rth rth merged commit d753d4d into scikit-learn:main Aug 6, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@glemaitre @samronsin
API deprecate plot_det_curve in favor of display class methods (sciki…
9246719 
…t-learn#19278)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glemaitre @rth @thomasjpfan