fix(cdk): list-template-manager should always emit latest value #1460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a8258e7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
github-actions
bot
added
🛂 Test
Codecov Report
@@ Coverage Diff @@
## main #1460 +/- ##
==========================================
+ Coverage 74.95% 76.81% +1.86%
==========================================
Files 151 113 -38
Lines 2951 2295 -656
Branches 531 392 -139
==========================================
- Hits 2212 1763 -449
+ Misses 617 429 -188
+ Partials 122 103 -19
Flags with carried forward coverage won't be shown. Click here to find out more. |
edbzn
approved these changes
Nov 22, 2022
|
I started to investigate to find out why coverage reports are broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
The list template manager emits an empty array after it received a value and detected no changes to render. This leads to unexpected value emissions through
rxFors rendercallback.Fix
The list template manager should always emit the latest set of data, even if no change was detected on new value input.
This is e.g. useful in scenarios where you rely on the renderCallback in order to hide a loading spinner after an asynchronous operation.
I'm thinking about a search bar triggering an http request and returning the same data as before.
rxForwouldn't render any new change, but the renderCallback should still indicate the change got processed.