Constant-time comparison for hook signature (#12) #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a straightforward boolean equality check for the hook signature opens a small vector for timing attacks; forcing constant-time comparison closes it up.
|
Wow, it's been over a year -- why hasn't this PR been merged in? This is a totally valid PR and adheres github's own advice: https://developer.github.com/webhooks/securing/ |
A bit more politeness to the people providing you with _free_ code would probably be in order here. Generally a "ping" is considered best when trying to get attention on issues that look stale but easily resolvable. Grow some manners or go away @matthauck, I have better things to do than deal with ungrateful and entitled devs. |
|
@rjz thanks for the patch, it's a pretty tiny vector but I'll buy it anyway. Sorry for missing this and the long delay, published as v0.5.1, I hope it's still helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a straightforward boolean equality check for the hook signature opens a small vector for timing attacks; forcing constant-time comparison closes it up.