Optimize javascript bundle #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natematykiewicz
approved these changes
Oct 8, 2020
|
Once you mentioned that the REPL change made it big, I was thinking extracting the REPL out of application.js would make a ton of sense. This PR looks great to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The current application javascript bundle size is really large (several MBs big) and takes forever for a browser to fully process. This is causing issues with the theme switcher setting the light/dark theme well after the DOM has started rendering and causing a flickering effect. See #573
This issue is caused by 2 main issues:
when I added the new repl page page, I packaged the entire Monaco editor in the JS application (which is several MBs big).
The Monaco editor is packaged in the same javascript bundle that is served for the docs pages.
Fixes
This PR solves both issues by:
File Before/After
Before
Application JS: 3.3MB
** After: **
Application JS: 70KB
Repl JS: 2.2Mb