-
Notifications
You must be signed in to change notification settings - Fork 34
Darkmode toggle take 2 #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import { Controller } from "stimulus" | ||
|
|
||
| function setLightMode(target) { | ||
| target.classList.replace("dark-switch", "light-switch") | ||
| document.body.dataset.theme = 'light' | ||
| } | ||
|
|
||
| function setDarkMode(target) { | ||
| target.classList.replace("light-switch", "dark-switch") | ||
| document.body.dataset.theme = 'dark' | ||
| } | ||
|
|
||
| export default class extends Controller { | ||
| static targets = ["switch"] | ||
|
|
||
| connect() { | ||
| const osDarkMode = window.matchMedia('(prefers-color-scheme: dark)').matches | ||
| const supportsLocalStorage = 'localStorage' in window | ||
|
|
||
| if (supportsLocalStorage) { | ||
| const darkMode = localStorage.getItem('rubyapi-darkMode') | ||
|
|
||
| if (darkMode !== null && darkMode === '1') { | ||
| setDarkMode(this.switchTarget) | ||
| } else if (osDarkMode && darkMode === null) { | ||
| setDarkMode(this.switchTarget) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| toggle() { | ||
| if (this.switchTarget.classList.contains('light-switch')) { | ||
| setDarkMode(this.switchTarget) | ||
| localStorage.setItem('rubyapi-darkMode', '1') | ||
| } else { | ||
| setLightMode(this.switchTarget) | ||
| localStorage.setItem('rubyapi-darkMode', '0') | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using https://fontawesome.com for the UI icons, which you can find here. Would we be able to use the icons here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let‘s do this in later Pull Request? I did not find ones on fontawesome that are better than current unicode ones. Ideally we could have CSS icons like the ones in https://justjavascript.com/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moon: https://fontawesome.com/icons/moon?style=solid
Sun: https://fontawesome.com/icons/sun?style=solid (a bit another, but seems OK)
Bulb icons (like in Twitter) are paid in Font Awesome.
Also sometimes I think we can have too many icons/buttons in the header, and there will be some drop-down menu, and then it'd be better to do just toggle with text, without icon.