Skip to content

handle base64 encoded dn attr #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2014
Merged

handle base64 encoded dn attr #123

merged 2 commits into from
Oct 12, 2014

Conversation

mattias-ohlsson
Copy link
Contributor

DN can be base64 encoded.

RFC 2849:

base64-distinguishedName = BASE64-UTF8-STRING
                           ; a distinguishedName which has been base64
                           ; encoded (see note 10, below)

@mattias-ohlsson
Copy link
Contributor Author

This pull request is a rebased version of: #94

@mtodd
Copy link
Member

mtodd commented Oct 12, 2014

@mattias-ohlsson awesome, thanks for following up on this (and for your patience)! Diff looks good, merging. I'll follow up on the Base64 stuff (as far as we're concerned, all the Ruby versions we support have it) and the tests.

mtodd added a commit that referenced this pull request Oct 12, 2014
@mtodd
Merge pull request #123 from mattias-ohlsson/master
9df2347 
handle base64 encoded dn attr
@mtodd mtodd merged commit 9df2347 into ruby-ldap:master Oct 12, 2014
@jch
Copy link
Member

jch commented Oct 13, 2014

👍

astratto pushed a commit to astratto/ruby-net-ldap that referenced this pull request Dec 18, 2015
@mtodd
Merge pull request ruby-ldap#123 from mattias-ohlsson/master
ad29c78 
handle base64 encoded dn attr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattias-ohlsson @mtodd @jch