Skip to content

ZJIT: Run against all tests #13950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ZJIT: Run against all tests #13950

wants to merge 3 commits into from
+64 −5

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jul 18, 2025 •
edited
Loading

  • make zjit-test-all now runs all test under /test, which includes several default gems' tests
  • Some additional exclusions have been added to /test/.excludes-zjit/
  • Since now zjit-test-all takes quite a while, I think we can run zjit-check instead of zjit-test on CI to get a faster feedback, even tho test_zjit.rb will be run twice (another time in zjit-test-all)

@st0012 st0012 force-pushed the zjit-expand-test-coverage branch from 38349cf to 39a02bf Compare July 18, 2025 16:17
@st0012 st0012 force-pushed the zjit-expand-test-coverage branch from de1124a to a056a5a Compare July 18, 2025 17:07
@st0012 st0012 changed the title ZJIT: Test against all tests under /test ZJIT: Run against all tests Jul 18, 2025
@st0012 st0012 force-pushed the zjit-expand-test-coverage branch from a056a5a to 5fb6475 Compare July 18, 2025 17:18
@st0012 st0012 marked this pull request as ready for review July 18, 2025 17:28
@matzbot matzbot requested a review from a team July 18, 2025 17:28
@tekknolagi
Copy link
Contributor

Can you explain the YAML changes please? I'm not sure the current description clears it up for me. There are too many suites and commands for me to keep track of.

@st0012
Copy link
Member Author

st0012 commented Jul 18, 2025 •
edited
Loading

zjit-test runs ZJIT's Rust tests. zjit-check runs both the Rust tests and test_zjit.rb.
So currently we have one job running ZJIT Rust tests, and let zjit-test-all run all Ruby tests, including test_zjit.rb.
After the change, one job will run both ZJIT Rust tests and test_zjit.rb, and zjit-test-all would still run test_zjit.rb but I think that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st0012 @tekknolagi