Skip to content

Fix 0.69 not compiling on ReScript 10 #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 5, 2022
Merged

Fix 0.69 not compiling on ReScript 10 #773

merged 3 commits into from
Oct 5, 2022

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Oct 5, 2022

Some errors were introduced in 394bd60.

@cknitt cknitt requested a review from MoOx October 5, 2022 06:51
@MoOx
Copy link
Member

MoOx commented Oct 5, 2022

@cknitt I got a small diff on package-lock. Curious to know what version of npm you have :)

MoOx
MoOx approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@MoOx MoOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix !

@MoOx MoOx merged commit e2847e7 into main Oct 5, 2022
@MoOx MoOx deleted the fix-compilation-rescript-10 branch October 5, 2022 10:15
@cknitt
Copy link
Member Author

cknitt commented Oct 5, 2022

@cknitt I got a small diff on package-lock. Curious to know what version of npm you have :)

It seems I have 7.11.2.

@MoOx
Copy link
Member

MoOx commented Oct 5, 2022

That's the reason then.

❯ node --version && npm --version
v16.13.2
8.19.1

MoOx added a commit that referenced this pull request Oct 5, 2022
@MoOx
Merge branch 'main' into rescript-10
cd7687b 
* main:
  "end" is not a reserved word anymore
  0.69.1
  Fix 0.69 not compiling on ReScript 10 (#773)
  0.69.0
  Create HitSlop & Rect module (closes #765)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoOx MoOx MoOx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknitt @MoOx