Get rid of @string/@int for polyvars #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoOx
previously approved these changes
Aug 10, 2022
cknitt
force-pushed
the
simplify-polyvars
branch
from
b04a62d to
1addf0c
Compare
|
Just noticed I had forgotten the ~pointerEvents: pointerEvents=?,in a few places. Updated the PR. |
cknitt
force-pushed
the
simplify-polyvars
branch
from
1addf0c to
dc3ca46
Compare
|
@cknitt Could you reopen this PR (create a new one yourself so you get proper credit) ? https://github.com/rescript-react-native/rescript-react-native/compare/main...simplify-polyvars?expand=1 |
|
Done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #748.
These are breaking changes, but I think that's ok - more breaking changes likely to come with #766.