Skip to content

Add Iris package #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Add Iris package #230

merged 1 commit into from
Jun 4, 2019

Conversation

bjlittle
Copy link
Contributor

@bjlittle bjlittle commented Jun 2, 2019

I'd love to get iris signed-up to the python3statement!

@@ -66,6 +66,7 @@ These projects pledge to drop Python 2 support in or before 2020.
- [![](assets/metpy.png)MetPy](https://unidata.github.io/MetPy)
- [![](assets/nengo.png)Nengo](https://www.nengo.ai/)
- [![](assets/pylast.png)pyLast](https://github.com/pylast/pylast) <!-- url:https://github.com/pylast/pylast sg:314 -->
- [![](assets/iris.png)iris](https://scitools.org.uk/iris/docs/latest/) <!-- url:https://github.com/SciTools/iris -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite sure about the sg:XXX, what should be added here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Carreau Thanks for the explanation for sg.... I've now already added the stargazers count for iris 😄

@Carreau
Copy link
Member

Carreau commented Jun 3, 2019 via email

@takluyver
Copy link
Member

Thanks! Have you already compressed the logo? If not, run scripts/squash-images.sh on it to make it as small as possible.

Have you discussed this with the other maintainers of iris? We try to ensure that no-one is surprised by seeing 'their' project on the statement.

Add Iris stargazers count
squash iris image + fix 2.x patch support eol
@Carreau
Copy link
Member

Carreau commented Jun 4, 2019

(rebased to fix conflicts).

@bjlittle
Copy link
Contributor Author

bjlittle commented Jun 4, 2019

@takluyver Thanks.

I'm the lead developer of iris at the Met Office, and I can confirm that we already have a core dev quorum agreement with the proposed plan to move to Python3.

We are planning to include this python3statement as part of our public announcement to the wider community on our plans for iris. We think it will add more gravitas to our announcement and also highlight the awesome work that you guys are doing to push package developers to commit to Python3 and inform the community in a transparent way.

Cheers

@takluyver
Copy link
Member

Thanks @bjlittle :-)

@takluyver takluyver merged commit 0950457 into python3statement:master Jun 4, 2019
@bjlittle
Copy link
Contributor Author

bjlittle commented Jun 4, 2019

@takluyver and @Carreau awesome thanks for your help.

Just checked https://python3statement.org/#sections40-timeline, but all the timelines appear to be missing. Did this PR break it on master? Or has something else happened? 😕

@takluyver
Copy link
Member

Ah, I think you might have missed out some commas in the JSON. I should have checked that before merging. 😉

Can I ask you to do another PR for that?

@bjlittle bjlittle mentioned this pull request Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants