Skip to content

4.6 API update #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Mar 29, 2020
Merged

4.6 API update #1723

merged 32 commits into from
Mar 29, 2020

Conversation

Poolitzer
Copy link
Member

@Poolitzer Poolitzer commented Jan 23, 2020 •
edited by Bibo-Joshi
Loading

docs need to be built and checked. Tests should run through now.

  • When API 4.5 #1508 is merged to master, merge master and update Message._parse_* to handle the MessageEntities.language attribute correctly. Doesn't actually do anything yet, but we should still add it to Message.text_html and friends
  • Make test_official fail again (i.e. partly revert improve CI #1716)

closes #1722

@Bibo-Joshi Bibo-Joshi added the ⚙️ bot-api affected functionality: bot-api label Jan 23, 2020
@Poolitzer
Copy link
Member Author

I am pretty sure I would need to add the new objects to the init file, didn't do it.

@Poolitzer Poolitzer added this to the 12.4.2 milestone Jan 23, 2020
@Poolitzer
Copy link
Member Author

Okay, all failed tests are unrelated, I think

@Poolitzer Poolitzer changed the title First take on 4.6 support 4.6 ali update Jan 23, 2020
@Poolitzer Poolitzer changed the title 4.6 ali update 4.6 API update Jan 23, 2020
Bibo-Joshi
Bibo-Joshi reviewed Jan 23, 2020
View reviewed changes
@Poolitzer
Copy link
Member Author

telegram/keyboardbutton.py:docstring of telegram.KeyboardButton:41: WARNING: Unexpected indentation.

I can't get rid of that, but I don't think I have inserted that error :D

@Bibo-Joshi Bibo-Joshi mentioned this pull request Jan 24, 2020
Merged
4 tasks
@Bibo-Joshi
Copy link
Member

telegram/keyboardbutton.py:docstring of telegram.KeyboardButton:41: WARNING: Unexpected indentation.

I can't get rid of that, but I don't think I have inserted that error :D

Yes you did ;P Don't put whitespaces on begging of lines - linebreaks count as whitespace.

Bibo-Joshi
Bibo-Joshi requested changes Jan 24, 2020
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Apart from my nitpicking below we should add a test files for the new KeyboardButtonPollType and PollAnswer or integrate it into test_keyboardbutton.py and test_poll.py, respectively.

@Poolitzer
Copy link
Member Author

I added the missing filter as discussed in private. Do I have to add tests?

@Bibo-Joshi Bibo-Joshi mentioned this pull request Jan 26, 2020
Merged
@Bibo-Joshi
Copy link
Member

Telegram added a note to KeyboardButton about which versions support request_poll. Please add this one here as well. I'll try to review again shortly :)

@Poolitzer
Copy link
Member Author

@Bibo-Joshi but I already did?

python-telegram-bot/telegram/keyboardbutton.py

Lines 53 to 54 in 7d25d19

:attr:`request_poll` option will only work in Telegram versions released after 23 January,
2020. Older clients will receive unsupported message.

Bibo-Joshi
Bibo-Joshi reviewed Jan 28, 2020
View reviewed changes
@python-telegram-bot python-telegram-bot deleted a comment from Poolitzer Jan 29, 2020
github-actions[bot]
github-actions bot reviewed Feb 2, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

@Poolitzer
Copy link
Member Author

Missing: Tests and docs for new handlers.

Maybe improving pollbot docs.

sharunkumar
sharunkumar suggested changes Feb 8, 2020
View reviewed changes
sharunkumar and others added 3 commits February 8, 2020 22:56
@sharunkumar
correct_option_id validated with None
8f1f251 
when trying to send a poll with correct option id 0 it was failing. Now None check is done so that even when 0 is passed it is assigned.
@Poolitzer
Merge pull request #1764 from sharunkumar/patch-1
a5e770f 
correct_option_id validated with None
@Poolitzer
improving example
a36ffd2
@Poolitzer
Copy link
Member Author

Poolitzer commented Feb 10, 2020 •
edited
Loading

Id live to have you "helping" ;P

Also, reminder to myself, I need to include the poll filter in the example

@Bibo-Joshi
Copy link
Member

Id live to have you "helping" ;P

Will try to. Probably will take a few days

@Bibo-Joshi
Copy link
Member

Here you go :-*
Took the liberty to simplify the example a bit and restore the intended behaviour of Filters.poll

@Poolitzer
Copy link
Member Author

Thank you very much :)

@Bibo-Joshi Bibo-Joshi mentioned this pull request Mar 6, 2020
Closed
@simonsmh
Copy link

When will this pull request get merged?

@Poolitzer
Copy link
Member Author

We dont like giving an ETA, sorry. That being said its on our list (obviously). Maintainers just need to find time in their life.

@simonsmh
Copy link

Actually I am using this branch for quite a long time and doesn't meet any problem so far. I'm just curious for why it doesn't get any update for nearly a month as I need some of the new feature to show my idea to others. Anyway thanks for your work.

jay-babu
jay-babu reviewed Mar 28, 2020
View reviewed changes
This was referenced Mar 28, 2020
Closed
Closed
@Bibo-Joshi Bibo-Joshi merged commit 55e3ecf into master Mar 29, 2020
@Bibo-Joshi Bibo-Joshi mentioned this pull request Mar 29, 2020
Merged
@Bibo-Joshi Bibo-Joshi deleted the 4.6-update branch March 29, 2020 09:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bibo-Joshi Bibo-Joshi Bibo-Joshi requested changes

@jay-babu jay-babu jay-babu left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@sharunkumar sharunkumar sharunkumar requested changes

Assignees
No one assigned
Labels
⚙️ bot-api affected functionality: bot-api
Projects
None yet
Milestone
12.4.4
Development

Successfully merging this pull request may close these issues.

API 4.6
5 participants
@Poolitzer @Bibo-Joshi @simonsmh @sharunkumar @jay-babu