Skip to content

if g:pymode_breakpoint_cmd is empty, skip pymode#breakpoint#operate #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

if g:pymode_breakpoint_cmd is empty, skip pymode#breakpoint#operate #840

wants to merge 1 commit into from

Conversation

timfeirg
Copy link

@timfeirg timfeirg commented Jan 28, 2018 •
edited
Loading

This PR aims to fix this:

When g:pymode_breakpoint_cmd is empty string, calling pymode#breakpoint#operate will just delete the given line, which can be confusing.

This is how:

  • Added a error message to let user know what's gone wrong, and skip the rest since there's nothing to do really.
  • When calculating g:pymode_breakpoint_cmd, try to find pdb package as well.

fmv1992 added a commit that referenced this pull request Jan 28, 2018
@fmv1992
merged issue #840: fixed pymode_breakpoint deleting line if no debugg…
371eba4 
…er was found
@fmv1992
Copy link
Contributor

fmv1992 commented Jan 28, 2018

thanks; fixed in commit 371eba4e7f334dc239053124dae94cf7da8d9c61 with minor changes

@fmv1992 fmv1992 closed this Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timfeirg @fmv1992