Fix #728, pass rope project to ImportTools init #802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmv1992
force-pushed
the
develop
branch
4 times, most recently
from
3f4fc36 to
60c638d
Compare
boatx
force-pushed
the
bugfix/issue-728
branch
from
72cffc9 to
f69f10a
Compare
|
Hi @diraol I've rebased my branch against develop. |
|
Hi @fmv1992 I think this is ready to be merged! =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #728 . As noted by @pieterdd and @soulomoon calling autoimport results in AttributeError. Rope ImportTools expect to get Project object as input argument to init function not PyCore object.