Show linters error list only if not empty #742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures tear down:
Is fixing those tests a priority? |
|
Actually can you help me get those tests running? Never got the exact gist of it... |
|
I can give it a shot. I'll ping you on Slack in case of any questions |
fmv1992
force-pushed
the
develop
branch
4 times, most recently
from
3f4fc36 to
60c638d
Compare
|
Hi @glujan can you please rebase your PR branch against our develop branch and then see if the tests are passing? |
|
@diraol Here you go, the branch is rebased and tests are green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #739 as suggested by @kevinkjt2000