no-op for un-evaluatable items in globals #25
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for compatibility with other libraries that inject extra variables, like unit testing with pytest.
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 62.35% 62.33% -0.02%
==========================================
Files 45 45
Lines 4362 4365 +3
Branches 735 735
==========================================
+ Hits 2720 2721 +1
- Misses 1335 1337 +2
Partials 307 307
Continue to review full report at Codecov.
|
|
Oh yes, that's a peculiar way to access a variable. How about |
encukou
added a commit
to encukou/python-ldap
that referenced
this pull request
Nov 27, 2017
This is for compatibility with other libraries that inject extra variables, like unit testing with pytest. Based on a suggestion by AlanCoding: python-ldap#25
This was referenced Nov 27, 2017
|
I'd use Filed as a PR: #35 |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request carries out what was suggested in the email:
https://mail.python.org/pipermail/python-ldap/2016q3/003789.html
The project that I am working on has had to keep the version of pytest pinned ever since encountering the problem mentioned here, because pytest puts decorators in the pattern of
@somethingas a key that shows up inside ofdir(). A major takeaway is that you should not count on keys inside ofdir()to be something that can be evaluated in all environments.https://github.com/ansible/awx/blob/devel/requirements/requirements_dev.txt#L8
If you could make this change, no existing workflow should be affected, and we will be able to upgrade pytest as soon as a new release of pytest-ldap is cut.
My alternative solution is that this diff would also suffice:
SCHEMA_ATTR_MAPPING = {} for _name in dir(): - o = eval(_name) + o = globals()[_name] if hasattr(o,'schema_attribute'): SCHEMA_CLASS_MAPPING[o.schema_attribute] = o SCHEMA_ATTR_MAPPING[o] = o.schema_attributeBy the way, thank you for taking over management of this project. No one responded to my email, but I am delighted to be able to make the pull request directly now.