Split io.py into multiple files
#448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriknw
added
hygiene
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting
io.pyinto separate files was brought up in #435 and #436, which I think is a good idea.I kept the submodules hidden in this PR (such as
_networkx.py), because I'm not sure I like the current names. Also, I think tab-completinggb.io.<TAB>is good enough for users to find the functions they want. Since each submodule probably won't have that many functions--all currently have two--I think it would detract if we had e.g.networkxin addition tofrom_networkxandto_networkxingb.io.Linting tools actually made this pretty easy to do, b/c they clean up imports I don't use and tell me which functions I need to import.
This PR does not yet use
automoduleas suggested in #436. I think we should still consider doing so.