Skip to content

Test upstream PR that adds support for complex dtypes on Windows #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Test upstream PR that adds support for complex dtypes on Windows #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90ae68a
Test upstream PR that adds support for complex dtypes on Windows
eriknw Feb 12, 2023
0314657
Force "suitesparse" backend in CI
eriknw Feb 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test_and_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ jobs:
shell: bash -l {0}
strategy:
# To "stress test" in CI, set `fail-fast` to `false` and perhaps add more items to `matrix.slowtask`
fail-fast: true
fail-fast: false
# The build matrix is [os]x[slowtask] and then randomly chooses [pyver] and [sourcetype].
# This should ensure we'll have full code coverage (i.e., no chance of getting unlucky),
# since we need to run all slow tests on Windows and non-Windoes OSes.
Expand Down Expand Up @@ -118,10 +118,10 @@ jobs:
source
upstream
weights: |
2
1
1
1
1000000
- name: Setup conda
uses: conda-incubator/setup-miniconda@v2
with:
Expand Down Expand Up @@ -204,7 +204,7 @@ jobs:
elif [[ ${{ steps.sourcetype.outputs.selected }} == "source" ]]; then
pip install --no-deps --no-binary=all suitesparse-graphblas
elif [[ ${{ steps.sourcetype.outputs.selected }} == "upstream" ]]; then
pip install --no-deps git+https://github.com/GraphBLAS/python-suitesparse-graphblas.git@main#egg=suitesparse-graphblas
pip install --no-deps git+https://github.com/GraphBLAS/python-suitesparse-graphblas.git@b65050921ea71606436f37279c225edaf95fc677#egg=suitesparse-graphblas
fi
pip install --no-deps -e .
- name: Unit tests
Expand Down
2 changes: 2 additions & 0 deletions graphblas/dtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@

# Default assumption unless FC32/FC64 are found in lib
_supports_complex = hasattr(_lib, "GrB_FC64") or hasattr(_lib, "GxB_FC64")
if not _supports_complex:
raise RuntimeError("Every OS should support complex dtypes now")


class DataType:
Expand Down
1 change: 1 addition & 0 deletions graphblas/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ def pytest_configure(config):
backend = "suitesparse" if np.random.rand() < 0.5 else "suitesparse-vanilla"
else:
backend = "suitesparse"
backend = "suitesparse" # XXX quick hack to force it
blocking = config.getoption("--blocking", True)
if blocking is None: # pragma: no branch
blocking = np.random.rand() < 0.5 if randomly else True
Expand Down